Skip to content

Disable flaky SSH tests on Windows #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
holgerfriedrich wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Disable flaky SSH tests on Windows #2550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d535cc
Disable flaky SSH tests on Windows
holgerfriedrich Apr 19, 2026
c984c96
more tests disabled
holgerfriedrich Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions itests/test/src/test/java/org/apache/karaf/itests/ssh/BundleSshCommandSecurityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*/
package org.apache.karaf.itests.ssh;

import org.junit.Assume;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.ops4j.pax.exam.junit.PaxExam;
Expand All @@ -32,6 +33,11 @@ public class BundleSshCommandSecurityTest extends SshCommandTestBase {

@Test
public void testBundleCommandSecurityViaSsh() throws Exception {
// Skip on Windows where PTY output can be garbled,
// when upgrading to Junit5, this can be replaced with @DisabledOnOs(OS.WINDOWS)
// TODO: remove this once we have a better solution for PTY output on Windows
Assume.assumeFalse(System.getProperty("os.name", "").toLowerCase().contains("win"));

String manageruser = "man" + System.nanoTime() + "_" + counter++;
String vieweruser = "view" + System.nanoTime() + "_" + counter++;

Expand Down
10 changes: 10 additions & 0 deletions itests/test/src/test/java/org/apache/karaf/itests/ssh/ConfigSshCommandSecurityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
*/
package org.apache.karaf.itests.ssh;

import org.junit.Assume;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.ops4j.pax.exam.junit.PaxExam;
Expand All @@ -33,6 +34,10 @@ public class ConfigSshCommandSecurityTest extends SshCommandTestBase {

@Test
public void testConfigCommandSecurityViaSsh() throws Exception {
// Skip on Windows where PTY output can be garbled,
// when upgrading to Junit5, this can be replaced with @DisabledOnOs(OS.WINDOWS)
// TODO: remove this once we have a better solution for PTY output on Windows
Assume.assumeFalse(System.getProperty("os.name", "").toLowerCase().contains("win"));
String manageruser = "man" + System.nanoTime() + "_" + counter++;
String vieweruser = "view" + System.nanoTime() + "_" + counter++;

Expand Down Expand Up @@ -90,6 +95,11 @@ private void testConfigEdits(String user, Result expectedEditResult, String pid,

@Test
public void testConfigCommandSecurityWithoutEditSessionViaSsh() throws Exception {
// Skip on Windows where PTY output can be garbled,
// when upgrading to Junit5, this can be replaced with @DisabledOnOs(OS.WINDOWS)
// TODO: remove this once we have a better solution for PTY output on Windows
Assume.assumeFalse(System.getProperty("os.name", "").toLowerCase().contains("win"));

String manageruser = "man" + System.nanoTime() + "_" + counter++;
String vieweruser = "view" + System.nanoTime() + "_" + counter++;

Expand Down
6 changes: 6 additions & 0 deletions itests/test/src/test/java/org/apache/karaf/itests/ssh/FeatureSshCommandSecurityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
package org.apache.karaf.itests.ssh;

import org.junit.Assert;
import org.junit.Assume;
import org.junit.Test;

/**
Expand All @@ -26,6 +27,11 @@ public class FeatureSshCommandSecurityTest extends SshCommandTestBase {

@Test
public void testFeatureCommandSecurityViaSsh() throws Exception {
// Skip on Windows where PTY output can be garbled,
// when upgrading to Junit5, this can be replaced with @DisabledOnOs(OS.WINDOWS)
// TODO: remove this once we have a better solution for PTY output on Windows
Assume.assumeFalse(System.getProperty("os.name", "").toLowerCase().contains("win"));

String vieweruser = "viewer" + System.nanoTime() + "_features";
String feature = "wrapper";

Expand Down
5 changes: 5 additions & 0 deletions itests/test/src/test/java/org/apache/karaf/itests/ssh/JaasSshCommandSecurityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;

import org.junit.Assume;
import org.junit.Test;

/**
Expand All @@ -27,6 +28,10 @@ public class JaasSshCommandSecurityTest extends SshCommandTestBase {

@Test
public void testJaasCommandSecurityViaSsh() throws Exception {
// Skip on Windows where PTY output can be garbled,
// when upgrading to Junit5, this can be replaced with @DisabledOnOs(OS.WINDOWS)
// TODO: remove this once we have a better solution for PTY output on Windows

String vieweruser = "viewer" + System.nanoTime() + "_jaas";

addViewer(vieweruser);
Expand Down
6 changes: 6 additions & 0 deletions itests/test/src/test/java/org/apache/karaf/itests/ssh/SystemCommandSecurityTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
package org.apache.karaf.itests.ssh;

import org.junit.Assert;
import org.junit.Assume;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.ops4j.pax.exam.junit.PaxExam;
Expand All @@ -31,6 +32,11 @@ public class SystemCommandSecurityTest extends SshCommandTestBase {

@Test
public void testSystemCommandSecurityViaSsh() throws Exception {
// Skip on Windows where PTY output can be garbled,
// when upgrading to Junit5, this can be replaced with @DisabledOnOs(OS.WINDOWS)
// TODO: remove this once we have a better solution for PTY output on Windows
Assume.assumeFalse(System.getProperty("os.name", "").toLowerCase().contains("win"));

String manageruser = "man" + System.nanoTime() + "_" + counter++;
String vieweruser = "view" + System.nanoTime() + "_" + counter++;

Expand Down