This repository was archived by the owner on Nov 11, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Added Issues Closed / Opened ratio in Issue trends #16
Open
amunz
wants to merge
2
commits into
apache:main
Choose a base branch
from
amunz:issues-ratio-trend
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the issues opened / issues closed ratio.
removed fractions import
Member
|
Hi Adam, this looks great. Can you snake-case it please? |
| ) | ||
| no_closers_before = res['aggregations']['closer']['value'] | ||
|
|
||
| issuesRatioBefore = round(float(no_issues_closed_before) / no_issues_created_before, 2) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @amunz
Suggested change
| issuesRatioBefore = round(float(no_issues_closed_before) / no_issues_created_before, 2) | |
| issues_ratio_before = round(float(no_issues_closed_before) / no_issues_created_before, 2)§ |
Let's make it python style. ;)
| no_closers_before = res['aggregations']['closer']['value'] | ||
|
|
||
| issuesRatioBefore = round(float(no_issues_closed_before) / no_issues_created_before, 2) | ||
| issuesRatioAfter = str(round(float(no_issues_closed) / no_issues_created, 2)) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| issuesRatioAfter = str(round(float(no_issues_closed) / no_issues_created, 2)) | |
| issues_ratio_after = str(round(float(no_issues_closed) / no_issues_created, 2)) |
Contributor
|
Hi folks. Please take a look #45. We are going to change the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider my contribution to add the metric issues closed / issues opened ratio. The metric is defined by the Chaoss project as an important metric for determining growth maturity and decline. More information on the metric can be found here.
Thank you for considering,
Adam