fix(json): use bytes sink for CBOR encoding - #3580
Merged
Merged
Conversation
PragmaTwice
approved these changes
Aug 9, 2026
jihuayu
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
string_sink<std::string>is incompatible with jsoncons 1.9.0 because the CBOR encoder appends buffers throughconst uint8_t *, whilestring_sink<std::string>expectsconst char *.Use
bytes_sink<std::string>, which is intended for binary output and is also used by jsoncons'encode_cborimplementation. It is compatible with jsoncons 1.8.1 and 1.9.0 and produces the same serialized CBOR output.Related downstream update: NixOS/nixpkgs#550324
Validation
./x.py build build-pr --ninja --unittest -j 8./x.py test cpp build-pr— 600 passed, 1 skipped./x.py test go build-pr -run 'TestJson/JSON_storage_format_CBOR' -count=1./x.py check format --clang-format-path clang-format-18./x.py check tidy build-pr -j 8 --clang-tidy-path clang-tidy-18 --run-clang-tidy-path run-clang-tidy-18./x.py check golangci-lintgit diff --checkPrepared with assistance from Amp for investigating jsoncons API compatibility, preparing the focused change, and running local validation.