Fix Tessellation error for holes that share the same leftmost vertex with an outer ring vertex#15700
Open
roblburris wants to merge 4 commits intoapache:mainfrom
Open
Fix Tessellation error for holes that share the same leftmost vertex with an outer ring vertex#15700roblburris wants to merge 4 commits intoapache:mainfrom
roblburris wants to merge 4 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apologies in advance if this is garbage, but I had Claude make an attempt at fixing the Tessellation error for the geometry in #15695:
All tests pass including a new one for the geometry linked in #15695. The description of the problem and fix seem correct but I'll defer to people more familiar with the nuances of Tessellator to verify this 😄