Add optional query bit size hint to KnnSearchStrategy.Hnsw#15708
Open
arup-chauhan wants to merge 2 commits intoapache:mainfrom
Open
Add optional query bit size hint to KnnSearchStrategy.Hnsw#15708arup-chauhan wants to merge 2 commits intoapache:mainfrom
arup-chauhan wants to merge 2 commits intoapache:mainfrom
Conversation
Signed-off-by: Arup Chauhan <arupchauhan.connect@gmail.com>
Author
|
Hey @benwtrent Implemented the first incremental step by adding an optional I’ve preserved backward compatibility, forwarded the hint through Next, I plan to wire the hint into the vector reader/scorer plumbing, and then follow up with a small PR that uses the hint for query-bit-aware behavior in the scalar-quantized scoring path. Looking forward to your feedback! |
Signed-off-by: Arup Chauhan <arupchauhan.connect@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces an optional query bit-size hint for
KnnSearchStrategy.Hnswas a first incremental step toward #15614.I intentionally limited the scope to search-strategy API plumbing and tests to keep risk low.
Default behavior remains unchanged: the new hint is metadata-only in this PR and does not alter scoring yet.
Changes
queryBitSizeHinttoKnnSearchStrategy.Hnsw.Hnsw(int filteredSearchThreshold)Hnsw(int filteredSearchThreshold, Integer queryBitSizeHint)> 0when non-null).queryBitSizeHint().equals/hashCodeforHnswto include the new hint.KnnSearchStrategy.Patienceconstructors to support hint passthrough.HnswQueueSaturationCollector#getSearchStrategy()to preserve and forward the hint when wrapping strategies.TestKnnSearchStrategyto cover:equals/hashCodebehaviorValidation
./gradlew -p lucene/core compileJava./gradlew -p lucene/core test --tests TestKnnSearchStrategy./gradlew -p lucene/core checkOnly tweak I made: removed “(after formatting fix)” since it passes now.