fix(tools): spell the OSV and CVE.org recipes with the framework runner prefix - #1339
Merged
Merged
Conversation
…er prefix The recipes added in #1326 invoke the dispatcher as a bare `vetted-op-read …`, but every permission rule and sandbox exclusion in the repository spells it with the runner prefix, and `tools/vetted-ops/README.md` writes it as `… vetted-op-read` with an explicit ellipsis for the variable part. An agent following these recipes literally therefore hits a permission prompt or a sandboxed run — the same recipe-versus-baseline mismatch #1320 set out to close, in a new spelling. The framework already has a settled convention for addressing its own `tools/<name>/` subtrees: `uv run --project <framework>/tools/<name>`, used by `privacy-llm`, `reproducible-archive` and others, with `<framework>` resolved per the placeholder table in AGENTS.md. These nine recipes were the outlier rather than a new question, so they now match it. Generated-by: Claude Opus 5
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vetted-op-read …, but every permission rule and sandbox exclusion in the repo spells it with the runner prefix — so an agent following them literally hits a permission prompt or a sandboxed run.tools/<name>/subtrees (uv run --project <framework>/tools/<name>, used byprivacy-llm,reproducible-archiveand others). These nine recipes were the outlier, not a new question.Type of change
tools/<system>/*.md)docs/,README.md,CONTRIBUTING.md)Test plan
prek run --all-filespasses<framework>is the documented placeholder for this use (AGENTS.md § Placeholder convention) and matches existing usage intools/privacy-llm/,tools/reproducible-archive/RFC-AI-0004 compliance
<framework>/<caller>placeholdersLinked issues
Refs #1320, Refs #1326
Notes for reviewers
Raised as a non-blocking note during review of #1326 and fixed here rather than lost in a merged PR.
The alternative was to document that
vetted-op-readis assumed onPATHand keep the recipes bare. I went with the prefixed form because it is what the rest of the repository already does and what the permission rules actually match — but if you would rather assumePATH, the fix is a sentence intools/vetted-ops/README.mdinstead and this PR should be closed.