-
Notifications
You must be signed in to change notification settings - Fork 981
[QDP] Add zero-copy amplitude batch encoding from float32 GPU tensors #1029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
viiccwen
wants to merge
8
commits into
apache:main
Choose a base branch
from
viiccwen:add-batch-f32-amplitude-encoding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,004
−136
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ea9dfe7
feat: add direct encoding method for float32 tensors
viiccwen 787052d
feat: implement batch amplitude encoding kernel for float32 inputs
viiccwen eff0d5e
feat: GPU state vector allocation to support precision selection
viiccwen 2a2d1e0
test: add unit tests
viiccwen b8e94b0
fix: pass precision to new_batch in encoder trait impls
viiccwen 8d41cbd
refactor: move imple from lib.rs to amplitude encoder file
viiccwen 0145332
fix: rebase error
viiccwen ce9d876
test: add tests
viiccwen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this file around lines 251–276 and 351–376, amplitude_encode_batch_kernel / _f32 compute input_base = sample_idx * input_len and then do reinterpret_cast<const double2*>(input_batch + input_base) + elem_pair / float2. For odd input_len and sample_idx > 0 this base pointer is only 8‑byte (double) / 4‑byte (float) aligned, not 16‑byte, so the double2/float2 loads are potentially misaligned. This alignment pattern already existed in the original f64 batch kernel and this PR copies it into the new f32 batch path; please either enforce even input_len at the Rust call‑site or rework the kernels to index from a properly aligned double2* / float2* base pointer with a scalar fallback.