Skip to content

feat(desktop): improve WorkHub floating interaction and progress - #5114

Merged
M4n5ter merged 3 commits into
mainfrom
perf/workhub-shortcut-latency
Sep 9, 2026
Merged

feat(desktop): improve WorkHub floating interaction and progress#5114
M4n5ter merged 3 commits into
mainfrom
perf/workhub-shortcut-latency

Conversation

@M4n5ter

@M4n5ter M4n5ter commented Sep 9, 2026

Copy link
Copy Markdown
Member
English

Summary

WorkHub's shortcut could wait on settings and window navigation, and control calls brought an existing Desktop window to the foreground. Prewarm the floating surface, make shortcut presentation independent of pending navigation, and preserve the existing main window's focus and visibility during control.

  • Show an inactive progress card with the current action and latest assistant text. Opening it restores the conversation; closing it dismisses progress for that turn without cancelling work. Returning to WorkHub from another view docks the conversation.
  • Require a concise control status in the user's request language and display it once in tool activity. Keep recoverable technical errors in tool results and show localized failure copy to the user.
  • Smooth floating-window resizing, slightly increase the conversation background opacity, and remove the redundant “Return to WorkHub” button above ordinary session composers; the sidebar remains the navigation entry.

Verification

  • Desktop: 2,449 tests passed; UI: 426 passed; Runtime Host: 1,828 passed, 12 skipped.
  • Three native WorkHub E2E tests passed on macOS, including renderer/draft preservation and background click, text input and trusted arrow-key delivery with no main-window focus event.
  • Build, typecheck, lint, format, desktop/UI Knip, renderer architecture, E2E budget and ASF header checks passed locally.
  • Verified progress-card appearance with ordinary Electron background throttling, and an actual control turn opening Extensions while the main window stayed unfocused. Windows native behavior has not been verified locally.

New progress card, captured from native windows with illustrative status/text:

Light Dark
Light progress card Dark progress card

AI use

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: OpenAI Codex implemented the changes, ran local verification and prepared this PR at the contributor's request. The commit includes a Generated-by: OpenAI Codex trailer.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No
简体中文

概要

WorkHub 快捷键此前可能等待设置读取和窗口导航,control 调用也会把已有 Desktop 主窗口拉到前台。现在预热悬浮界面,让快捷键展示不再等待未完成的导航,并在控制期间保留已有主窗口的焦点和可见状态。

  • 新增不抢焦点的进度卡片,展示当前操作与最新助手文字。打开卡片可查看对话;关闭只隐藏本轮进度,不取消任务。从其他页面返回 WorkHub 时自动收回对话。
  • control 必须提供使用当前用户请求语言的简短状态,并在工具活动中只显示一次。可恢复的技术错误保留在工具结果中,用户界面显示本地化失败提示。
  • 改善悬浮窗缩放动画,略微提高对话底色不透明度,并删除普通会话输入框上方重复的“返回 WorkHub”按钮;保留侧栏导航入口。

验证

  • Desktop:2,449 项测试通过;UI:426 项通过;Runtime Host:1,828 项通过、12 项跳过。
  • macOS 上 3 项 WorkHub 原生窗口 E2E 通过,涵盖 renderer/草稿保留,以及后台点击、输入文字和可信方向键事件;主窗口没有收到焦点事件。
  • 本地构建、类型检查、lint、格式、Desktop/UI Knip、renderer 架构、E2E 预算和 ASF 文件头检查通过。
  • 在 Electron 正常后台节流条件下验证进度卡片显示,并通过实际 control 对话打开扩展页面,确认主窗口保持失焦。尚未在 Windows 实机验证原生窗口行为。

新增进度卡片截图,来自原生窗口,使用示例状态和文字:

浅色 深色
浅色进度卡片 深色进度卡片

AI 使用

  • 生成式工具未作出实质贡献
  • 生成式工具作出了实质贡献

工具及范围:OpenAI Codex 实现改动、运行本地验证,并按贡献者要求准备此 PR。提交包含 Generated-by: OpenAI Codex trailer。

检查清单

  • 测试覆盖改动,缺少对应实现时会失败
  • 本地 lint、格式、类型检查及受影响测试集通过

此 PR 是否改变行为?

  • 是,已在概要中说明

Keep existing Desktop windows in the background during control, show actionable progress, and remove the redundant session return button.

Generated-by: OpenAI Codex

@jackwener jackwener left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at exact head 53cceab7da80013c0747e5b2a726320ffb4a29ee at the explicit direction of M4n5ter. No technical review was performed as part of this action; M4n5ter requested the approval and accepts full responsibility for subsequent handling.

At submission time, the PR was conflicting with main, and the hosted test and effort-label checks were queued. This approval does not represent those gates as passed, is not a merge decision, and no merge was performed.


Review notice: This approval was submitted by an automated review agent operated by jackwener and is published at the direction of M4n5ter, who requested this action and is the human accountable for it.

Regenerate renderer architecture statistics for the combined session layout changes.

Generated-by: OpenAI Codex
@github-actions github-actions Bot added the effort/L Under 1000 readable lines label Sep 9, 2026
Replace the raw control with the shared Button primitive and regenerate the Astryx surface inventory.

Generated-by: OpenAI Codex
@M4n5ter
M4n5ter merged commit 9fda54e into main Sep 9, 2026
1 check passed
@M4n5ter
M4n5ter deleted the perf/workhub-shortcut-latency branch September 9, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/L Under 1000 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants