feat(desktop): improve WorkHub floating interaction and progress - #5114
Merged
Conversation
Keep existing Desktop windows in the background during control, show actionable progress, and remove the redundant session return button. Generated-by: OpenAI Codex
jackwener
approved these changes
Sep 9, 2026
jackwener
left a comment
Member
There was a problem hiding this comment.
Approved at exact head 53cceab7da80013c0747e5b2a726320ffb4a29ee at the explicit direction of M4n5ter. No technical review was performed as part of this action; M4n5ter requested the approval and accepts full responsibility for subsequent handling.
At submission time, the PR was conflicting with main, and the hosted test and effort-label checks were queued. This approval does not represent those gates as passed, is not a merge decision, and no merge was performed.
Review notice: This approval was submitted by an automated review agent operated by jackwener and is published at the direction of M4n5ter, who requested this action and is the human accountable for it.
Regenerate renderer architecture statistics for the combined session layout changes. Generated-by: OpenAI Codex
Replace the raw control with the shared Button primitive and regenerate the Astryx surface inventory. Generated-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English
Summary
WorkHub's shortcut could wait on settings and window navigation, and control calls brought an existing Desktop window to the foreground. Prewarm the floating surface, make shortcut presentation independent of pending navigation, and preserve the existing main window's focus and visibility during control.
Verification
New progress card, captured from native windows with illustrative status/text:
AI use
Tool(s) and scope: OpenAI Codex implemented the changes, ran local verification and prepared this PR at the contributor's request. The commit includes a
Generated-by: OpenAI Codextrailer.Checklist
Does this PR entail a change in behavior?
简体中文
概要
WorkHub 快捷键此前可能等待设置读取和窗口导航,control 调用也会把已有 Desktop 主窗口拉到前台。现在预热悬浮界面,让快捷键展示不再等待未完成的导航,并在控制期间保留已有主窗口的焦点和可见状态。
验证
新增进度卡片截图,来自原生窗口,使用示例状态和文字:
AI 使用
工具及范围:OpenAI Codex 实现改动、运行本地验证,并按贡献者要求准备此 PR。提交包含
Generated-by: OpenAI Codextrailer。检查清单
此 PR 是否改变行为?