Skip to content

Let resolverVersion control the whole resolver stack - #697

Merged
slachiewicz merged 1 commit into
masterfrom
resolver-version-covers-spi-and-util
Aug 23, 2026
Merged

Let resolverVersion control the whole resolver stack#697
slachiewicz merged 1 commit into
masterfrom
resolver-version-covers-spi-and-util

Conversation

@slachiewicz

Copy link
Copy Markdown
Member

resolverVersion names four resolver artifacts, but maven-resolver-spi and maven-resolver-util are not among them — they arrive transitively from maven-core at 1.4.1. Raising the property therefore produces a mixed stack, and maven-resolver-impl cannot be wired against a 1.4.1 spi:

null returned by binding at org.eclipse.sisu.wire.LocatorWiring
 but DefaultRepositorySystemSessionFactory.repoSystem is not @Nullable
  while locating org.eclipse.aether.RepositorySystem

That is what #691 hits — 9 of 10 CheckstyleReportTest cases error before any assertion runs. It is an incomplete bump rather than an incompatibility.

Declaring the two missing artifacts at ${resolverVersion} makes the property mean what it says. The version stays at 1.4.1, so nothing changes today.

Verified locally at both versions, mvn verify -DskipITs:

resolverVersion result
1.4.1 (this PR) BUILD SUCCESS, 26/26
1.9.27 (this PR + #691) BUILD SUCCESS, 26/26
1.9.27 (#691 alone) 9 errors

Whether to then take #691 is a separate call: mavenVersion is 3.6.3, which ships resolver 1.4.1, so the bump would test the plugin against a combination no user runs. Pinning resolver to the Maven baseline and having dependabot ignore it — as maven-surefire already does — is the alternative.

This change was created with AI assistance.

maven-resolver-spi and maven-resolver-util arrived transitively from
maven-core at 1.4.1, so raising the property left them behind and sisu
could no longer wire RepositorySystem.
@slachiewicz slachiewicz added maintenance build Pull requests that change the build process labels Aug 23, 2026
@slachiewicz
slachiewicz marked this pull request as ready for review August 23, 2026 09:10
@slachiewicz
slachiewicz merged commit f6f3f96 into master Aug 23, 2026
22 checks passed
@slachiewicz
slachiewicz deleted the resolver-version-covers-spi-and-util branch August 23, 2026 10:21
@github-actions github-actions Bot added this to the 3.6.1 milestone Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Pull requests that change the build process maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant