Let resolverVersion control the whole resolver stack - #697
Merged
Conversation
maven-resolver-spi and maven-resolver-util arrived transitively from maven-core at 1.4.1, so raising the property left them behind and sisu could no longer wire RepositorySystem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolverVersionnames four resolver artifacts, butmaven-resolver-spiandmaven-resolver-utilare not among them — they arrive transitively frommaven-coreat 1.4.1. Raising the property therefore produces a mixed stack, andmaven-resolver-implcannot be wired against a 1.4.1 spi:That is what #691 hits — 9 of 10
CheckstyleReportTestcases error before any assertion runs. It is an incomplete bump rather than an incompatibility.Declaring the two missing artifacts at
${resolverVersion}makes the property mean what it says. The version stays at 1.4.1, so nothing changes today.Verified locally at both versions,
mvn verify -DskipITs:Whether to then take #691 is a separate call:
mavenVersionis 3.6.3, which ships resolver 1.4.1, so the bump would test the plugin against a combination no user runs. Pinning resolver to the Maven baseline and having dependabot ignore it — as maven-surefire already does — is the alternative.This change was created with AI assistance.