[MCOMPILER-598] Add regression test for text blocks with unescaped quotes - #1117
Merged
Conversation
…otes The old source module parser (plexus-java with qdox) used to parse every source file in the source folder. Text blocks containing unescaped double quotes made qdox fail with a ParseException, e.g. syntax error @[9,2] in .../ServiceImpl.java. Regression test verifies that a modular project with a service provider class containing such a text block compiles.
Contributor
Author
|
Installed distributions |
elharo
marked this pull request as draft
August 29, 2026 14:31
The bug is that unescaped double quotes inside a text block break the source parser. It does not involve modularity or service providers, so drop the module-info.java, Service interface and ServiceImpl wrapper. Keep a single TextBlock class with the multiline string and assert only that this class was compiled.
elharo
marked this pull request as ready for review
August 30, 2026 10:48
slawekjaranowski
approved these changes
Aug 31, 2026
slawekjaranowski
left a comment
slawekjaranowski
left a comment
Member
There was a problem hiding this comment.
should be also added to 3.x branch
|
@elharo Please assign appropriate label to PR according to the type of change. |
elharo
added
the
skip-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test for #875 (MCOMPILER-598).
fixes #875
A source file that contains a text block with an unescaped double quote must compile. The old plexus-java/qdox-based source-module parser (3.x) parsed every source file in the source folder and failed on such text blocks with
syntax error @[9,2]/@[23,1]. This branch has no qdox/plexus-java, but the IT locks the behavior so it is not reintroduced.The IT is intentionally minimal: a single
TextBlockclass containing the multiline string, and averify.groovythat asserts the class was compiled. No module-info or service-provider machinery is needed to exercise the bug.Sanity-checked on master:
mvn -Prun-its -Dinvoker.test=MCOMPILER-598 install-> IT passes.