Open
Conversation
Instead to jump between ways how to perform "change detection" (decide should existing target file be overwritten), make it a configurable strategy. Before 3.4.0 it was timestamp, post 3.4.0 it was content, but in any case users were left short. Fixes apache/maven-resources-plugin#453
cstamas
commented
Feb 20, 2026
| } | ||
| } | ||
| } | ||
| copyFilePermissions(from, to); |
Member
Author
There was a problem hiding this comment.
This bit is confusing me: to me it sounds like if copied then apply perms, but we have UT that ensures perms are always copied...
Member
Author
There was a problem hiding this comment.
nope, i missed at method beginning: we modify perms
It simply copied if target does not exists, and stands off if target exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead to jump between ways how to perform "change detection" (decide should existing target file be overwritten), make it a configurable strategy.
Before 3.4.0 it was timestamp, post 3.4.0 it was content, but in any case users were left short.
Fixes
apache/maven-resources-plugin#453
#321
#271