Allow to give alternative source directories for sites#1261
Merged
Conversation
kwin
force-pushed
the
feature/configurablesourcedirectories-newmaster
branch
2 times, most recently
from
a6e4143 to
6701331
Compare
michael-o
reviewed
Apr 13, 2026
| docRenderingContext.getExtension(), | ||
| docRenderingContext.isEditable(), | ||
| docRenderingContext.getGenerator()); | ||
| docRenderingContext.getBasedir(), document, docRenderingContext.getGenerator()); |
Member
Author
There was a problem hiding this comment.
All other arguments are null or false anyhow for report generated documents, please look at the javadoc of the constructors.
michael-o
reviewed
Apr 13, 2026
| mainSiteDirectory.addAlternativeEditableSourceDirectory(additionalSiteSourceDirectory); | ||
| } | ||
| } | ||
| context.addSiteDirectory(mainSiteDirectory); |
Member
There was a problem hiding this comment.
How is the locale cleanly retained?
Member
Author
There was a problem hiding this comment.
Can you clarify what is the concern here? The site directory just got an additional field (locale is not touched).
kwin
force-pushed
the
feature/configurablesourcedirectories-newmaster
branch
2 times, most recently
from
ac56c00 to
d2518d0
Compare
kwin
force-pushed
the
feature/configurablesourcedirectories-newmaster
branch
from
d2518d0 to
3aa5590
Compare
Add ITs for verifying edit link This relates to apache/maven-doxia-sitetools#277
kwin
force-pushed
the
feature/configurablesourcedirectories-newmaster
branch
from
3aa5590 to
78196e9
Compare
|
@kwin Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to
apache/maven-doxia-sitetools#277
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.