Conversation
This re-renders modified Doxia sources automatically. Deprecate "run" goal in favour of this one. This closes #1266
Member
|
Will check next week. |
michael-o
reviewed
Apr 20, 2026
Member
There was a problem hiding this comment.
What about reports? In 3.20.x I have made it possible to re-render reports, even external ones. Is it still the case here? Is the improvement not to have Jetty anymore? The asciidoctor plugin has a very similar feature, worth looking at and it never worked reliably for me.
| Artifact skinArtifact = | ||
| siteTool.getSkinArtifactFromRepository(repoSession, remoteProjectRepositories, siteModel.getSkin()); | ||
|
|
||
| getLog().info(buffer().a("Rendering content with ") |
Member
There was a problem hiding this comment.
Why move this to the actual impls?
Member
Author
There was a problem hiding this comment.
Because this method isn't performing rendering, just calculating context. This is now not always followed by rendering with the new goal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-renders modified Doxia sources automatically. Deprecate "run" goal in favour of this one.
This closes #1266
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.