Pull #2291: Modernize codebase with Java improvements - Unnecessary throws

[Pankraz76]

Pull #2291: Modernize codebase with Java improvements - Unnecessary throws

Apply:

• https://docs.openrewrite.org/recipes/staticanalysis/unnecessarythrows

Prerequisite:

• Pull #2292: Modernize codebase with Java improvements - SOC DefaultModelProcessor#read #2292

fix:

Ref:

• Modernize codebase with Java improvements #2277
• Unnecessary throws checkstyle/checkstyle#17005

[gnodet]

This may lead to incompatibilities if someone overrides a protected method and actually throw one exception that you removed. No incompatible change in compat modules is required.

[Pankraz76]

This may lead to incompatibilities if someone overrides a protected method and actually throw one exception that you removed

new contract is not to throw; with checked it wont compile and runtime is always possible.

No incompatible change in compat modules is required.

so undo in this module and then any good ?

[Pankraz76]

No incompatible change in compat modules is required.

done.

[gnodet]

If you remove a throws clause from a protected method, any class that overrides this method won't be able to throw that exception, so that's an API change.

[Pankraz76]

how to fix this permanent @timtebeek ? We dont have checkstyle for this.

Do we have the (local) dry run causing build failure check available?

I do not want to overload and spam PR´s like its done in rewrite. Ideally this breaks and fixes locally on dev´s machine/cost.

Thank you so much for this tool. Its a great needed help. We enlight the code so much.

• [POC] Migrate JUnit asserts to AssertJ - impl #2307

This codebase is very smart as the code will format itself just like aimed in

• [POC] Modernize codebase - Automatically fix Checkstyle violations #2300

but, its still not capable of fixing all like imports. This we will cover with help of rewrite again.

[timtebeek]

Thanks all! Indeed we should not be making changes to an API that was explicitly marked as protected with exceptions declared;

• UnnecessaryThrows should not change API for protected methods openrewrite/rewrite-static-analysis#553

[Pankraz76]

wip reopen: wait for bugfix release or rewrite.