Remove unused DefaultPluginXmlFactory#fromXml/toXml#2327
Closed
Pankraz76 wants to merge 1 commit intoapache:masterfrom
Closed
Remove unused DefaultPluginXmlFactory#fromXml/toXml#2327Pankraz76 wants to merge 1 commit intoapache:masterfrom
DefaultPluginXmlFactory#fromXml/toXml#2327Pankraz76 wants to merge 1 commit intoapache:masterfrom
Conversation
Pankraz76
force-pushed
the
fix-write-test-fix-fromXml
branch
from
0022e03 to
46952b0
Compare
Pankraz76
changed the title
DefaultPluginXmlFactory#fromXmlDefaultPluginXmlFactory#fromXml/toXml
Pankraz76
force-pushed
the
fix-write-test-fix-fromXml
branch
from
46952b0 to
3b0409b
Compare
Pankraz76
commented
May 12, 2025
| */ | ||
| public static PluginDescriptor fromXml(@Nonnull String xml) throws XmlReaderException { | ||
| return new DefaultPluginXmlFactory().fromXmlString(xml); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
is this actively in use?
Contributor
Author
|
wait for enabler |
Pankraz76
force-pushed
the
fix-write-test-fix-fromXml
branch
from
3b0409b to
3dda054
Compare
Pankraz76
force-pushed
the
fix-write-test-fix-fromXml
branch
from
3dda054 to
60084e9
Compare
Contributor
|
Those methods may be used by other code that integrates with Maven. We do not remove public APIs. |
Contributor
Author
where is this code? Will be notice on ci level? |
Contributor
Author
is kind of random. We should know about our clients and user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused
DefaultPluginXmlFactory#fromXml/toXmloutputStreamdestination;requestinstead ofpathinDefaultPluginXmlFactory#write#2312