use try-with-resources statement in Mojos#2443
Closed
Pankraz76 wants to merge 1 commit intoapache:masterfrom
Closed
use try-with-resources statement in Mojos#2443Pankraz76 wants to merge 1 commit intoapache:masterfrom
try-with-resources statement in Mojos#2443Pankraz76 wants to merge 1 commit intoapache:masterfrom
Conversation
Pankraz76
commented
Jun 5, 2025
| try { | ||
| out.close(); | ||
| } catch (IOException e) { | ||
| // just ignore |
Contributor
Author
There was a problem hiding this comment.
7 files 7 times dry - count check seems valid.
- lucky number seven
Pankraz76
force-pushed
the
fix-FileOutputStream
branch
from
2df729c to
c0b9bc9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Pankraz76
changed the title
try-with-resources statement in Mojostry-with-resources statement in Mojos
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
No need to have Jira anymore. Why the same code multiple times? Maybe some improvement? |
Contributor
Author
poor software design.
yes can fix this dedicated afterwards. |
olamy
reviewed
Jun 7, 2025
...in-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java
Show resolved
Hide resolved
Pankraz76
changed the title
try-with-resources statement in Mojostry-with-resources statement in Mojos
elharo
approved these changes
Jun 8, 2025
This comment has been minimized.
This comment has been minimized.
Pankraz76
force-pushed
the
fix-FileOutputStream
branch
from
c0b9bc9 to
e1d3214
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
should we split into smaller or wait? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY,where you replace
MNG-XXXandSUMMARYwith the appropriate JIRA issue.[MNG-XXX] SUMMARY.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.