[S1161] chore: Add missing @Override to overriding and implementing methods

api/maven-api-cli/src/main/java/org/apache/maven/api/cli/mvnup/UpgradeOptions.java

@@ -118,6 +118,7 @@ public interface UpgradeOptions extends Options {
      * @param callback a callback to use for interpolation
      * @return a new UpgradeOptions instance with interpolated values
      */
+    @Override
     @Nonnull
     UpgradeOptions interpolate(UnaryOperator<String> callback);
 }

compat/maven-compat/src/test/java/org/apache/maven/artifact/deployer/ArtifactDeployerTest.java

@@ -46,6 +46,7 @@ class ArtifactDeployerTest extends AbstractArtifactComponentTestCase {
     @Inject
     private SessionScope sessionScope;
 
+    @Override
     protected String component() {
         return "deployer";
     }

compat/maven-compat/src/test/java/org/apache/maven/artifact/installer/ArtifactInstallerTest.java

@@ -41,6 +41,7 @@ class ArtifactInstallerTest extends AbstractArtifactComponentTestCase {
     @Inject
     private SessionScope sessionScope;
 
+    @Override
     protected String component() {
         return "installer";
     }

compat/maven-compat/src/test/java/org/apache/maven/artifact/resolver/TestFileWagon.java

@@ -35,6 +35,7 @@ public class TestFileWagon extends FileWagon {
     private TestTransferListener testTransferListener;
     private boolean insideGet;
 
+    @Override
     @Deprecated
     protected void getTransfer(Resource resource, File destination, InputStream input, boolean closeInput, int maxSize)
             throws TransferFailedException {

compat/maven-compat/src/test/java/org/apache/maven/artifact/testutils/TestFileManager.java

@@ -152,6 +152,7 @@ public String getFileContents(File file, String encoding) throws IOException {
         return FileUtils.fileRead(file, encoding);
     }
 
+    @Override
     protected void finalize() throws Throwable {
         maybeWarnAboutCleanUp();
 

compat/maven-compat/src/test/java/org/apache/maven/project/inheritance/AbstractProjectInheritanceTestCase.java

@@ -48,6 +48,7 @@ protected File projectFile(String groupId, String artifactId) {
     // The local repository for this category of tests
     // ----------------------------------------------------------------------
 
+    @Override
     protected File getLocalRepositoryPath() {
         return getTestFile("target/test-classes/inheritance-repo/" + getTestSeries());
     }

compat/maven-embedder/src/main/java/org/apache/maven/cli/ExtensionConfigurationModule.java

@@ -68,6 +68,7 @@ static class ExtensionInterpolator extends MavenTransformer {
             super(transformer);
         }
 
+        @Override
         public XmlNode transform(XmlNode node) {
             return super.transform(node);
         }

compat/maven-embedder/src/main/java/org/eclipse/sisu/plexus/PlexusXmlBeanConverter.java

@@ -80,6 +80,7 @@ public final class PlexusXmlBeanConverter implements PlexusBeanConverter {
     // Public methods
     // ----------------------------------------------------------------------
 
+    @Override
     @SuppressWarnings({"unchecked", "rawtypes"})
     public Object convert(final TypeLiteral role, final String value) {
         if (value.trim().startsWith("<")) {

impl/maven-cli/src/main/java/org/apache/maven/cling/extensions/ExtensionConfigurationModule.java

@@ -68,6 +68,7 @@ static class ExtensionInterpolator extends MavenTransformer {
             super(transformer);
         }
 
+        @Override
         public XmlNode transform(XmlNode node) {
             return super.transform(node);
         }

impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvnup/UpgradeInvokerRequest.java

@@ -66,6 +66,7 @@ public UpgradeInvokerRequest(
     /**
      * The mandatory Upgrade options.
      */
+    @Override
     @Nonnull
     public UpgradeOptions options() {
         return options;

impl/maven-core/src/main/java/org/apache/maven/configuration/internal/EnhancedConfigurationConverter.java

@@ -33,6 +33,7 @@
  * interface.
  */
 class EnhancedConfigurationConverter extends ObjectWithFieldsConverter {
+    @Override
     protected Object fromExpression(
             final PlexusConfiguration configuration, final ExpressionEvaluator evaluator, final Class<?> type)
             throws ComponentConfigurationException {

impl/maven-core/src/main/java/org/apache/maven/session/scope/internal/SessionScope.java

@@ -46,6 +46,7 @@ public static <T> Provider<T> seededKeyProvider(Class<? extends T> clazz) {
         return SessionScope.<T>seededKeySupplier(clazz)::get;
     }
 
+    @Override
     protected boolean isTypeAnnotation(Class<? extends Annotation> annotationType) {
         return "org.apache.maven.api.di.Typed".equals(annotationType.getName())
                 || "org.eclipse.sisu.Typed".equals(annotationType.getName())

impl/maven-core/src/test/java/org/apache/maven/lifecycle/LifecycleExecutorSubModulesTest.java

@@ -60,6 +60,7 @@ class LifecycleExecutorSubModulesTest extends AbstractCoreMavenComponentTestCase
     @Inject
     private ExceptionHandler exceptionHandler;
 
+    @Override
     protected String getProjectsDirectory() {
         return "src/test/projects/lifecycle-executor";
     }

impl/maven-core/src/test/java/org/apache/maven/lifecycle/LifecycleExecutorTest.java

@@ -69,6 +69,7 @@ class LifecycleExecutorTest extends AbstractCoreMavenComponentTestCase {
     @Inject
     private MojoDescriptorCreator mojoDescriptorCreator;
 
+    @Override
     protected String getProjectsDirectory() {
         return "src/test/projects/lifecycle-executor";
     }

impl/maven-core/src/test/java/org/apache/maven/lifecycle/internal/stub/CompletionServiceStub.java

@@ -44,6 +44,7 @@ public CompletionServiceStub(boolean finishImmediately) {
         this.finishImmediately = finishImmediately;
     }
 
+    @Override
     public Future<ProjectSegment> submit(Callable<ProjectSegment> task) {
         FutureTask<ProjectSegment> projectBuildFutureTask = new FutureTask<>(task);
         projectBuildFutureTasks.add(projectBuildFutureTask);

impl/maven-core/src/test/java/org/apache/maven/plugin/PluginManagerTest.java

@@ -43,6 +43,7 @@ class PluginManagerTest extends AbstractCoreMavenComponentTestCase {
     @Inject
     private DefaultBuildPluginManager pluginManager;
 
+    @Override
     protected String getProjectsDirectory() {
         return "src/test/projects/plugin-manager";
     }

impl/maven-core/src/test/java/org/apache/maven/plugin/internal/MavenPluginValidatorTest.java

@@ -39,6 +39,7 @@ class MavenPluginValidatorTest extends AbstractCoreMavenComponentTestCase {
     @Inject
     private MavenPluginValidator mavenPluginValidator;
 
+    @Override
     protected String getProjectsDirectory() {
         return "src/test/projects/default-maven";
     }

impl/maven-xml/src/main/java/org/apache/maven/internal/xml/DefaultXmlService.java

@@ -213,6 +213,7 @@ private void writeNode(XMLStreamWriter xmlWriter, XmlNode node) throws XMLStream
      *   </ol></li>
      * </ol>
      */
+    @Override
     @SuppressWarnings("checkstyle:MethodLength")
     public XmlNode doMerge(XmlNode dominant, XmlNode recessive, Boolean childMergeOverride) {
         // TODO: share this as some sort of assembler, implement a walk interface?

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng0768OfflineModeTest.java

@@ -62,6 +62,7 @@ public void testitMNG768() throws Exception {
         final List<String> requestedUris = Collections.synchronizedList(new ArrayList<>());
 
         Handler repoHandler = new AbstractHandler() {
+            @Override
             public void handle(
                     String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response)
                     throws IOException {

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng2305MultipleProxiesTest.java

@@ -137,6 +137,7 @@ private void addHttpsConnector(Server server, String keyStorePath, String keySto
     }
 
     static class RepoHandler extends AbstractHandler {
+        @Override
         public void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response)
                 throws IOException {
             PrintWriter writer = response.getWriter();

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng3599useHttpProxyForWebDAVMk2Test.java

@@ -66,6 +66,7 @@ public MavenITmng3599useHttpProxyForWebDAVMk2Test() {
     @BeforeEach
     protected void setUp() throws Exception {
         Handler handler = new AbstractHandler() {
+            @Override
             public void handle(
                     String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response)
                     throws IOException {

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4428FollowHttpRedirectTest.java

@@ -167,6 +167,7 @@ static class RedirectHandler extends AbstractHandler {
             this.connector = connector;
         }
 
+        @Override
         public void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response)
                 throws IOException {
             System.out.println("Handling " + request.getMethod() + " " + request.getRequestURL());

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5280SettingsProfilesRepositoriesOrderTest.java

@@ -140,6 +140,7 @@ private static final class RepoHandler extends AbstractHandler {
 
         private volatile boolean artifactRequestedFromRepo2;
 
+        @Override
         public void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response)
                 throws IOException {
             String uri = request.getRequestURI();
@@ -183,6 +184,7 @@ private class PluginRepoHandler extends AbstractHandler {
 
         private volatile boolean pluginRequestedFromRepo2;
 
+        @Override
         public void handle(String target, Request baseRequest, HttpServletRequest request, HttpServletResponse response)
                 throws IOException {
             String uri = request.getRequestURI();

its/core-it-suite/src/test/java/org/apache/maven/it/TestSuiteOrdering.java

@@ -818,6 +818,7 @@ int getIndex(ClassDescriptor cd) {
         return i != null ? i : -1;
     }
 
+    @Override
     public void orderClasses(ClassOrdererContext context) {
         context.getClassDescriptors().stream()
                 .filter(cd -> !MISSED_TESTS.contains(cd.getTestClass()))

its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckMojo.java

@@ -72,6 +72,7 @@ public class CheckMojo extends AbstractMojo {
      *
      * @throws MojoFailureException If the output file could not be created.
      */
+    @Override
     public void execute() throws MojoExecutionException, MojoFailureException {
         Properties componentProperties = new Properties();
 

its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/CheckThreadSafetyMojo.java

@@ -71,6 +71,7 @@ public class CheckThreadSafetyMojo extends AbstractMojo {
      *
      * @throws MojoExecutionException If the output file could not be created.
      */
+    @Override
     public void execute() throws MojoExecutionException {
         Properties componentProperties = new Properties();
 

its/core-it-support/core-it-plugins/maven-it-plugin-active-collection/src/main/java/org/apache/maven/plugin/coreit/DumpRepoLayoutsMojo.java

@@ -72,6 +72,7 @@ public class DumpRepoLayoutsMojo extends AbstractMojo {
      *
      * @throws MojoFailureException If the output file could not be created.
      */
+    @Override
     public void execute() throws MojoExecutionException, MojoFailureException {
         Properties layoutProperties = new Properties();
 

its/core-it-support/core-it-plugins/maven-it-plugin-all/src/main/java/org/apache/maven/plugin/coreit/AggregatorDependenciesMojo.java

@@ -43,6 +43,7 @@ public class AggregatorDependenciesMojo extends AbstractMojo {
     @Parameter(property = "aggregator.touchFile", defaultValue = "${project.build.directory}/touch.txt")
     private File touchFile;
 
+    @Override
     public void execute() throws MojoExecutionException {
         getLog().info("[MAVEN-CORE-IT-LOG] Touching file: " + touchFile);
 

its/core-it-support/core-it-plugins/maven-it-plugin-artifact/src/main/java/org/apache/maven/plugin/coreit/AttachMojo.java

@@ -77,6 +77,7 @@ public class AttachMojo extends AbstractMojo {
      *
      * @throws MojoFailureException If the attached file has not been set.
      */
+    @Override
     public void execute() throws MojoExecutionException, MojoFailureException {
         getLog().info("[MAVEN-CORE-IT-LOG] Attaching artifact file: " + attachedFile);
         getLog().info("[MAVEN-CORE-IT-LOG] type=" + artifactType + ", classifier=" + artifactClassifier);

its/core-it-support/core-it-plugins/maven-it-plugin-artifact/src/main/java/org/apache/maven/plugin/coreit/AttachPomMojo.java

@@ -58,6 +58,7 @@ public class AttachPomMojo extends AbstractMojo {
      *
      * @throws MojoFailureException If the artifact file has not been set.
      */
+    @Override
     public void execute() throws MojoExecutionException, MojoFailureException {
         getLog().info("[MAVEN-CORE-IT-LOG] Attaching POM to main artifact: " + pomFile);
 

its/core-it-support/core-it-plugins/maven-it-plugin-artifact/src/main/java/org/apache/maven/plugin/coreit/CollectMojo.java

@@ -90,6 +90,7 @@ public class CollectMojo extends AbstractMojo {
      *
      * @throws MojoFailureException If the artifact file has not been set.
      */
+    @Override
     public void execute() throws MojoExecutionException, MojoFailureException {
         getLog().info("[MAVEN-CORE-IT-LOG] Collecting artifacts");
 

its/core-it-support/core-it-plugins/maven-it-plugin-artifact/src/main/java/org/apache/maven/plugin/coreit/CustomRepositoryLayout.java

@@ -33,6 +33,7 @@ public String getId() {
         return "id";
     }
 
+    @Override
     public String pathOf(Artifact artifact) {
         ArtifactHandler artifactHandler = artifact.getArtifactHandler();
 
@@ -52,10 +53,12 @@ public String pathOf(Artifact artifact) {
         return path.toString();
     }
 
+    @Override
     public String pathOfLocalRepositoryMetadata(ArtifactMetadata metadata, ArtifactRepository repository) {
         return metadata.getLocalFilename(repository);
     }
 
+    @Override
     public String pathOfRemoteRepositoryMetadata(ArtifactMetadata metadata) {
         return metadata.getRemoteFilename();
     }

its/core-it-support/core-it-plugins/maven-it-plugin-artifact/src/main/java/org/apache/maven/plugin/coreit/DeployFileMojo.java

@@ -116,6 +116,7 @@ public class DeployFileMojo extends AbstractMojo {
      *
      * @throws MojoExecutionException If any artifact could not be deployed.
      */
+    @Override
     public void execute() throws MojoExecutionException, MojoFailureException {
         getLog().info("[MAVEN-CORE-IT-LOG] Deploying artifacts");
 

its/core-it-support/core-it-plugins/maven-it-plugin-artifact/src/main/java/org/apache/maven/plugin/coreit/DeployMojo.java

@@ -54,6 +54,7 @@ public class DeployMojo extends AbstractRepoMojo {
      *
      * @throws MojoExecutionException If any artifact could not be installed.
      */
+    @Override
     public void execute() throws MojoExecutionException {
         getLog().info("[MAVEN-CORE-IT-LOG] Deploying project artifacts");
 

its/core-it-support/core-it-plugins/maven-it-plugin-artifact/src/main/java/org/apache/maven/plugin/coreit/InstallArtifactsMojo.java

@@ -75,6 +75,7 @@ public class InstallArtifactsMojo extends AbstractMojo {
     @Parameter(defaultValue = "repo")
     private String repositoryName;
 
+    @Override
     public void execute() throws MojoExecutionException, MojoFailureException {
 
         ArtifactRepositoryLayout artifactRepositoryLayout = new FlatRepositoryLayout();
@@ -117,6 +118,7 @@ public String getId() {
             return "id";
         }
 
+        @Override
         public String pathOf(Artifact artifact) {
             ArtifactHandler artifactHandler = artifact.getArtifactHandler();
 
@@ -136,6 +138,7 @@ public String pathOf(Artifact artifact) {
             return path.toString();
         }
 
+        @Override
         public String pathOfLocalRepositoryMetadata(ArtifactMetadata metadata, ArtifactRepository repository) {
             return pathOfRepositoryMetadata(metadata.getLocalFilename(repository));
         }
@@ -148,6 +151,7 @@ private String pathOfRepositoryMetadata(String filename) {
             return path.toString();
         }
 
+        @Override
         public String pathOfRemoteRepositoryMetadata(ArtifactMetadata metadata) {
             return pathOfRepositoryMetadata(metadata.getRemoteFilename());
         }

its/core-it-support/core-it-plugins/maven-it-plugin-artifact/src/main/java/org/apache/maven/plugin/coreit/InstallMojo.java

@@ -45,6 +45,7 @@ public class InstallMojo extends AbstractRepoMojo {
      *
      * @throws MojoExecutionException If any artifact could not be installed.
      */
+    @Override
     public void execute() throws MojoExecutionException {
         getLog().info("[MAVEN-CORE-IT-LOG] Installing project artifacts");
 

its/core-it-support/core-it-plugins/maven-it-plugin-artifact/src/main/java/org/apache/maven/plugin/coreit/LatestMojo.java

@@ -45,6 +45,7 @@ public class LatestMojo extends AbstractMojo {
     /**
      * Runs this mojo.
      */
+    @Override
     public void execute() throws MojoExecutionException {
         Versioning versioning = new Versioning();
         versioning.setLatest(projectArtifact.getVersion());

its/core-it-support/core-it-plugins/maven-it-plugin-artifact/src/main/java/org/apache/maven/plugin/coreit/ReleaseMojo.java

@@ -46,6 +46,7 @@ public class ReleaseMojo extends AbstractMojo {
     /**
      * Runs this mojo.
      */
+    @Override
     public void execute() throws MojoExecutionException, MojoFailureException {
         Artifact artifact = project.getArtifact();
         artifact.setRelease(true);

its/core-it-support/core-it-plugins/maven-it-plugin-artifact/src/main/java/org/apache/maven/plugin/coreit/ResolveMojo.java

@@ -89,6 +89,7 @@ public class ResolveMojo extends AbstractMojo {
      *
      * @throws MojoExecutionException If the artifact could not be resolved
      */
+    @Override
     public void execute() throws MojoExecutionException {
         getLog().info("[MAVEN-CORE-IT-LOG] Resolving artifacts");
 

its/core-it-support/core-it-plugins/maven-it-plugin-artifact/src/main/java/org/apache/maven/plugin/coreit/ResolveTransitiveMojo.java

@@ -99,6 +99,7 @@ public class ResolveTransitiveMojo extends AbstractMojo {
      *
      * @throws MojoExecutionException If the artifacts couldn't be resolved.
      */
+    @Override
     public void execute() throws MojoExecutionException {
         getLog().info("[MAVEN-CORE-IT-LOG] Resolving artifacts");
 

its/core-it-support/core-it-plugins/maven-it-plugin-artifact/src/main/java/org/apache/maven/plugin/coreit/SetMojo.java

@@ -58,6 +58,7 @@ public class SetMojo extends AbstractMojo {
      *
      * @throws MojoFailureException If the artifact file has not been set.
      */
+    @Override
     public void execute() throws MojoExecutionException, MojoFailureException {
         getLog().info("[MAVEN-CORE-IT-LOG] Setting main artifact file: " + mainFile);
 

its/core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/AssignmentCompatibleMojo.java

@@ -54,6 +54,7 @@ public class AssignmentCompatibleMojo extends AbstractMojo {
      *
      * @throws MojoExecutionException If the output file could not be created.
      */
+    @Override
     public void execute() throws MojoExecutionException {
         ClassLoader coreRealm = Mojo.class.getClassLoader();
         ClassLoader pluginRealm = getClass().getClassLoader();

its/core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/InstanceofMojo.java

@@ -78,6 +78,7 @@ public class InstanceofMojo extends AbstractMojo {
      *
      * @throws MojoExecutionException If the output file could not be created.
      */
+    @Override
     public void execute() throws MojoExecutionException, MojoFailureException {
         Class type;
         try {

its/core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/src/main/java/org/apache/maven/plugin/coreit/LoadDependenciesMojo.java

@@ -61,6 +61,7 @@ public class LoadDependenciesMojo extends AbstractLoadMojo {
      *
      * @throws MojoExecutionException If the output file could not be created.
      */
+    @Override
     public void execute() throws MojoExecutionException {
         URL[] urls = new URL[classPath.size()];
         for (int i = 0; i < urls.length; i++) {