Fix default name evaluation for CDI beans

[NicolaIsotta]

This PR fixes the evaluation of the default name for CDI beans to strictly align with the CDI specifications.

Quoting CDI 1.1 specs:

The default name for a managed bean is the unqualified class name of the bean class, after converting the first character to lower case.
For example, if the bean class is named ProductList, the default bean name is productList.

Subsequent specifications all maintain the exact same text. Here is the latest: Jakarta EE CDI 4.1.

Historical Notes

I'm not exactly sure why the behavior was originally changed. My guess is that some implementations weren't perfectly aligned with the specifications at the time. For historical context on the deviation, see:

• NetBeans Bugzilla Issue #249438
• Related StackOverflow discussion
• commit

NB: this currently targets master, but it would be nice to have this in NB30

---

^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

• are all your own work, and you have the right to contribute them.
• are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

1. Was this PR correctly labeled, did the right tests run? When did they run?
2. Is this PR squashed?
3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

[matthiasblaesing]

This looks sane to me. From a quick read I think the authors of the special casing from https://bz.apache.org/netbeans/show_bug.cgi?id=249438 have mixed up the managed bean specification and the java beans specification.

At least CDI 1.1 and JSF 2.3 agree on the format.

[matthiasblaesing]

Only eyeballed this, but makes sense.

@NicolaIsotta how did you test this?

[NicolaIsotta]

I discovered the issue because the web.beans module is called from the EL module for code completion, eg. in jsf pages.
Suppose you have a bean like this (the first 2 chars must be uppercase):

@Named
@RequestScoped
public class JBean {
    
    private String value = "value";

    public String getValue() {
        return value;
    }

    public void setValue(String value) {
        this.value = value;
    }
}

In the xhtml, Netbeans will suggest this:

While it's actually available as #{jBean} (as per the CDI spec), can be simply verified by putting this in the xhtml:

\#{JBean.value}= #{JBean.value}<br/>
\#{jBean.value}= #{jBean.value}

The output is this:

I do have a runnable jetty project if needed.

[matthiasblaesing]

@NicolaIsotta thanks for your explanation. Indeed I just wanted to ensure that proper testing happened.

You'd like to get this into NB30 and there might be an option for that. For that please rebase your PR onto the delivery branch (ensure that only your single commit is moved!). After that update this PR and change the target branch for the PR to delivery.

@ebarboni you set milestone to NB31 - would it be ok to still move this to NB30, if Nicola makes the changes outlined in the previous paragraph? The current behavior is indeed broken and the new behavior is correct to my understanding of the JSF and CDI specifications. I tested this PR and it does the right thing.