Skip to content

CSS: Add support for psudo klasse :host-context - #9710

Merged
matthiasblaesing merged 1 commit into
apache:masterfrom
matthiasblaesing:css_host_context
Oct 14, 2026
Merged

CSS: Add support for psudo klasse :host-context#9710
matthiasblaesing merged 1 commit into
apache:masterfrom
matthiasblaesing:css_host_context

Conversation

@matthiasblaesing

@matthiasblaesing matthiasblaesing commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@matthiasblaesing matthiasblaesing added this to the NB32 milestone Oct 12, 2026
@matthiasblaesing matthiasblaesing added the CSS [ci] enable web job label Oct 12, 2026
mbien
mbien reviewed Oct 13, 2026
View reviewed changes
Comment thread ide/css.lib/src/org/netbeans/modules/css/lib/Css3Lexer.java Outdated
@@ -213,15 +213,15 @@ public Css3Lexer(CharStream input) {
public Css3Lexer(CharStream input, RecognizerSharedState state) {
super(input,state);
}
@Override public String getGrammarFileName() { return "ide\\css.lib\\src\\org\\netbeans\\modules\\css\\lib\\Css3.g"; }
@Override public String getGrammarFileName() { return "/home/matthias/src/netbeans/ide/css.lib/src/org/netbeans/modules/css/lib/Css3.g"; }

@mbien mbien Oct 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that it returns a hardcoded, absolute path as name

other occurrences:
https://github.com/search?q=repo%3Aapache%2Fnetbeans+%22%40Override+public+String+getGrammarFileName%28%29+%7B+return%22&type=code

@matthiasblaesing

matthiasblaesing commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

@ebarboni @mbien thank you both for looking into this. As both of you noticed the paths and I wanted to get rid of them for a long time, I finally bit the bullet. The generation is still not stable as the state order and such seems to change on each generation, but at least it is a bit better.

@ebarboni

ebarboni commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

looks ok to merge.

@matthiasblaesing
matthiasblaesing merged commit b96be97 into apache:master Oct 14, 2026
29 checks passed
@mbien

mbien commented Oct 14, 2026

Copy link
Copy Markdown
Member

this might be causing failures in testPartitialFormatting: org.netbeans.modules.css.editor.indent.CssIndenterTest

we will see for sure when master finished running again.

@matthiasblaesing

matthiasblaesing commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

I'm building master locally and look into this. I'm pretty sure though, that I ran both CSS Editor and CSS Library tests locally.

@matthiasblaesing

matthiasblaesing commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

Ok, locally built 9fc08e3 and ran the tests from all CSS modules. All run green (including the one reported to be failing in CI/CD).

@mbien

mbien commented Oct 14, 2026

Copy link
Copy Markdown
Member

@matthiasblaesing thanks for checking, sorry for the false alarm. I just didn't remember the web job failing often and it lined up given the css context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbien mbien mbien left review comments

Assignees

No one assigned

Labels

CSS [ci] enable web job

Projects

None yet

Milestone

NB32

Development

Successfully merging this pull request may close these issues.

3 participants

@matthiasblaesing @ebarboni @mbien