Skip to content

NIFI-16162 Deprecated org.apache.nifi.stream.io.StreamUtils copy method and replaced it with the java.io.Inputstream transferTo method - #11521

Open
dan-s1 wants to merge 2 commits into
apache:mainfrom
dan-s1:NIFI-16162
Open

NIFI-16162 Deprecated org.apache.nifi.stream.io.StreamUtils copy method and replaced it with the java.io.Inputstream transferTo method#11521
dan-s1 wants to merge 2 commits into
apache:mainfrom
dan-s1:NIFI-16162

Conversation

@dan-s1

@dan-s1 dan-s1 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

NIFI-16162

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

….io.StreamUtils and replaced them with java.io.Inputstream method equivalents
@dan-s1 dan-s1 changed the title NIFI-16162 Deprecated methods copy and skip in org.apache.nifi.streamio.StreamUtils and replaced them with java.io.Inputstream method equivalents NIFI-16162 Deprecated methods copy and skip in org.apache.nifi.stream.io.StreamUtils and replaced them with java.io.Inputstream method equivalents Aug 7, 2026
@dan-s1

dan-s1 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@exceptionfactory I am not sure how to proceed. It seems as though the skip method in org.apache.nifi.stream.io.StreamUtils is not exactly equivalent to java.io.InputStream skipNBytes as when I changed line 927 in org.apache.nifi.controller.repository.FileSystemRepository it caused the unit test testContentNotFoundExceptionThrownIfResourceClaimTooShort in org.apache.nifi.controller.repository.TestFileSystemRepository to fail. Please advise.

@exceptionfactory exceptionfactory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-s1, given that skip is different, I recommend backing out that change and focus this down to the copy method, if that is exactly equivalent.

@dan-s1

dan-s1 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@exceptionfactory Thanks! That seems equivalent as I tried running the individual unit tests each time I made changes. I will back out the skip changes and reword the ticket.

@dan-s1 dan-s1 changed the title NIFI-16162 Deprecated methods copy and skip in org.apache.nifi.stream.io.StreamUtils and replaced them with java.io.Inputstream method equivalents NIFI-16162 Deprecated method copy of org.apache.nifi.stream.io.StreamUtils and replaced it with the java.io.Inputstream transferTo method Aug 7, 2026
@dan-s1 dan-s1 changed the title NIFI-16162 Deprecated method copy of org.apache.nifi.stream.io.StreamUtils and replaced it with the java.io.Inputstream transferTo method NIFI-16162 Deprecated org.apache.nifi.stream.io.StreamUtils copy method and replaced it with the java.io.Inputstream transferTo method Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants