Skip to content

arch/arm: Fix FlexCAN config initializers clobbering rx_pin instead of enable_high #19721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Javinator9889 wants to merge 3 commits into
base: master
Choose a base branch
from
+11 −11
Open

arch/arm: Fix FlexCAN config initializers clobbering rx_pin instead of enable_high #19721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86f6e99
arch/s32k1xx: initializers clobbering rx_pin instead of enable_high
Javinator9889 Aug 6, 2026
1eea747
arch/kinetis: initializers clobbering rx_pin instead of enable_high
Javinator9889 Aug 6, 2026
96c505e
arch/s32k3xx: initializers clobbering rx_pin instead of enable_high
Javinator9889 Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions arch/arm/src/kinetis/kinetis_flexcan.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,11 +268,11 @@ static const struct flexcan_config_s kinetis_flexcan2_config =
.tx_pin = PIN_CAN2_TX,
.rx_pin = PIN_CAN2_RX,
#ifdef PIN_CAN2_ENABLE
.enable_pin = PIN_CAN2_ENABLE,
.rx_pin = CAN2_ENABLE_HIGH,
.enable_pin = PIN_CAN2_ENABLE,
.rx_pin = CAN2_ENABLE_OUT,
#else
.enable_pin = 0,
.rx_pin = 0,
.enable_pin = 0,
.enable_high = 0,
#endif
.bus_irq = KINETIS_IRQ_CAN2_BUS,
.error_irq = KINETIS_IRQ_CAN2_ERROR,
Expand Down
8 changes: 4 additions & 4 deletions arch/arm/src/s32k1xx/s32k1xx_flexcan.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,11 +273,11 @@ static const struct flexcan_config_s s32k1xx_flexcan2_config =
.tx_pin = PIN_CAN2_TX,
.rx_pin = PIN_CAN2_RX,
#ifdef PIN_CAN2_ENABLE
.enable_pin = PIN_CAN2_ENABLE,
.rx_pin = CAN2_ENABLE_HIGH,
.enable_pin = PIN_CAN2_ENABLE,
.rx_pin = CAN2_ENABLE_OUT,
#else
.enable_pin = 0,
.rx_pin = 0,
.enable_pin = 0,
.enable_high = 0,
#endif
.bus_irq = S32K1XX_IRQ_CAN2_BUS,
.error_irq = S32K1XX_IRQ_CAN2_ERROR,
Expand Down
6 changes: 3 additions & 3 deletions arch/arm/src/s32k3xx/s32k3xx_flexcan.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,11 +305,11 @@ static const struct flexcan_config_s s32k3xx_flexcan2_config =
.rx_pin = PIN_CAN2_RX,
.no_buffers = 64,
#ifdef PIN_CAN2_ENABLE
.enable_pin = PIN_CAN2_ENABLE,
.enable_pin = PIN_CAN2_ENABLE,
.enable_high = CAN2_ENABLE_OUT,
#else
.enable_pin = 0,
.rx_pin = 0,
.enable_pin = 0,
.enable_high = 0,
#endif
#ifdef PIN_CAN2_STB
.stb_pin = PIN_CAN2_STB,
Expand Down
Loading