feat(lister.go): Add opendal_list_options_set_versions and opendal_list_options_set_deleted#7645
Open
FrankYang0529 wants to merge 1 commit into
Open
feat(lister.go): Add opendal_list_options_set_versions and opendal_list_options_set_deleted#7645FrankYang0529 wants to merge 1 commit into
FrankYang0529 wants to merge 1 commit into
Conversation
Member
|
Hey could you please take a look at CI? Ping me anytime, thanks! |
18ec42e to
ed1741d
Compare
dentiny
reviewed
May 30, 2026
dentiny
reviewed
May 30, 2026
This was referenced May 30, 2026
db8b102 to
51be13a
Compare
Member
|
Hi @FrankYang0529 , do you mind re-requesting review and ping me when ready? Thanks! |
dentiny
reviewed
Jun 2, 2026
|
|
||
| var parsedOverrides map[string]bool | ||
|
|
||
| func getCapOverrides() map[string]bool { |
Member
There was a problem hiding this comment.
I think I've already added the util function to a more centralized place, could you please use that instead?
2d938cd to
1e71d79
Compare
1e71d79 to
8e49846
Compare
Member
=== CONT TestBehavior/WriteWithUserMetadata
SIGSEGV: segmentation violation
PC=0x1017c4fac m=4 sigcode=2 addr=0x100000
signal arrived during cgo execution
goroutine 82 gp=0x140003f56c0 m=4 mp=0x1400005fb08 [syscall]:
runtime.cgocall(0x1004463c0, 0x14000efd1e0)
/Users/runner/hostedtoolcache/go/1.22.5/arm64/src/runtime/cgocall.go:157 +0x44 fp=0x140004cc8c0 sp=0x140004cc880 pc=0x1002f0f84
github.com/ebitengine/purego.syscall_syscall15X(0x1017c4f68, 0x14000106060, 0x12976c6fc, 0x0, 0x140001081c8, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
/Users/runner/go/pkg/mod/github.com/ebitengine/purego@v0.8.4/syscall_sysv.go:24 +0x158 fp=0x140004cc9c0 sp=0x140004cc8c0 pc=0x1004456c8I met a similar CI failure on my PR as well, could be an existing issue on main branch |
Member
|
@FrankYang0529 You might need to rerun the failed CI to confirm, but I should have fixed the segfault issue -- don't see it any longer since the fix commit. |
…st_options_set_deleted Signed-off-by: PoAn Yang <payang@apache.org>
2745e56 to
67b2351
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7632
Rationale for this change
The Go binding lacked support for listing object versions and delete markers, which are already supported in the Rust core via
list_with_versionsandlist_with_deletedcapabilities.What changes are included in this PR?
versionsanddeletedfields toopendal_list_options, with corresponding setter functionsopendal_list_options_set_versionsandopendal_list_options_set_deleted.list_with_versionsandlist_with_deletedfields toopendal_capabilityand itsFrom<core::Capability>mapping.ListWithVersions(bool)andListWithDeleted(bool)functional options, FFI wrappers, andCapability.ListWithVersions()/Capability.ListWithDeleted()methods.Are there any user-facing changes?
Two new functional options are now available when calling
op.List():AI Usage Statement
OpenCode with claude-sonnet-4.6.