HDDS-15000. Improve S3 audit log stack traces#10097
Open
adoroszlai wants to merge 8 commits intoapache:masterfrom
Open
HDDS-15000. Improve S3 audit log stack traces#10097adoroszlai wants to merge 8 commits intoapache:masterfrom
adoroszlai wants to merge 8 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Audit log shows only the last two elements of stack traces. For several failed S3 Gateway requests it is always the same:
due to two levels of
newErrorcalls.This PR changes code to avod chained
newErrorcalls by creatingOS3Exceptionin variousnewErrorimplementations. Related changes to avoid duplication:OS3Exceptioncreation:S3ErrorTable) instead of separate variablesresourcenewErrornewErrorto reducenullarguments in callers.BucketEndpoint#translateExceptiontoS3ErrorTable(renamed totranslateResultCode), add more cases toswitch. ChangeObjectEndpointto rely on result code translation innewError.Related minor fix:
ERRORinstead ofSUCCESS, becauseNOT_FOUNDerror is handled in the outerdeletemethod, nothandleDeleteRequest. This is now moved to let audit log reflect the correct result.https://issues.apache.org/jira/browse/HDDS-15000
How was this patch tested?
Before:
After:
Before:
After:
Before:
After:
https://github.com/adoroszlai/ozone/actions/runs/24665673476