refactor(realtime): move offset handling to Paimon readers - #269
Open
lxy-9602 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #158
This PR moves real-time offset handling from
RealtimeStoreplugins into the Paimon read and write layers.The main changes are:
offset_beginfromRealtimeStore::CreateQueryReaders. Store plugins now return candidate rows without applying visibility offsets.enable_predicate_pushdownfromRealtimeQueryContext. Callers decide whether a predicate should be passed to the plugin._REALTIME_OFFSETto append-mode transport batches before they are handed to the real-time store.RealtimeOffsetBatchReaderto filter rows by the visible half-open offset range and remove_REALTIME_OFFSETfrom query output.RealtimeOffsetBatchReaderandKeyValueDataFileRecordReaderfor primary-key real-time reads.KeyValueDataFileRecordReaderto accept aBatchReader. File row positions remain available when the wrapped reader is aFileBatchReader.Tests
Added
RealtimeOffsetBatchReaderTest.API and Format
This PR changes the public real-time store plugin API:
RealtimeStore::CreateQueryReadersno longer acceptsoffset_begin.RealtimeQueryContextno longer containsenable_predicate_pushdown._REALTIME_OFFSETfield.Documentation
Generative AI tooling
Generated-by: OpenAI Codex (GPT-5)