Repository navigation
[vortex] Fix incorrect floating-point predicate pushdown - #10985
Open
zhouyc-ali wants to merge 2 commits into
Open
zhouyc-ali wants to merge 2 commits into
zhouyc-ali wants to merge 2 commits into
Conversation
Decline FLOAT/DOUBLE value predicate pushdown because Vortex and Paimon use different NaN comparison semantics. Retain null checks and safe conjunct pushdown, with regressions for candidate preservation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Paimon and Vortex use different NaN comparison semantics. For FLOAT/DOUBLE columns containing NaNs, native filtering can drop matching rows even for finite literals such as
value > 0. Residual filtering cannot recover those rows.Decline floating-point value predicates in the Vortex converter so the caller can evaluate them with Paimon's residual filter. Keep
IS NULL/IS NOT NULLand supported AND conjuncts pushed down. Floating-point filters may read more rows as a result.Tests
verify: 73 tests passed; 4 optional Java/Python E2E tests skipped. Checkstyle, Spotless, Maven Enforcer and Apache RAT passed.