Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Ray 2.60.0 defaults to
shuffle_v2. Its sorted reduce fails when real update blocks and the sentinel have different Arrow schemas, or when a map with no batches emits a zero-column, zero-row shard. Align routed update blocks with the sentinel schema before grouping.For the affected Ray 2.60.0 groupings, register a callback on a copy of the dataset context. It removes schema-less empty shards before the sorted reducer while keeping typed empty shards. Row-ID reads stay lazy and continue to use the configured shuffle strategy.
Tests
shuffle_v2passed all six previously failing tests and 24 related tests covering lazy reads, grouped writes, and routing.hash_shufflepassed the same six tests.