Skip to content

[hive] Fix query failure when dynamic filters are unavailable #9448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArnavBalyan wants to merge 1 commit into
base: master
Choose a base branch
from
+26 −0
Open

[hive] Fix query failure when dynamic filters are unavailable #9448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ector-common/src/main/java/org/apache/paimon/hive/SearchArgumentToPredicateConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,9 @@ private Predicate convertLeaf(PredicateLeaf leaf) {
.collect(Collectors.toList()));
case BETWEEN:
List<Object> literalList = leaf.getLiteralList();
if (literalList == null || literalList.size() < 2) {
throw new UnsupportedOperationException("BETWEEN literals are not available.");
}
return builder.between(
idx,
toLiteral(columnType, literalList.get(0)),
Expand Down
23 changes: 23 additions & 0 deletions ...r-common/src/test/java/org/apache/paimon/hive/SearchArgumentToPredicateConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.apache.hadoop.hive.ql.io.sarg.PredicateLeaf;
import org.apache.hadoop.hive.ql.io.sarg.SearchArgument;
import org.apache.hadoop.hive.ql.io.sarg.SearchArgumentFactory;
import org.apache.hadoop.hive.ql.io.sarg.SearchArgumentImpl.PredicateLeafImpl;
import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
import org.junit.jupiter.api.Test;

Expand Down Expand Up @@ -258,6 +259,28 @@ public void testBetween() {
assertExpected(sarg, expected);
}

@Test
public void testUnavailableBetween() {
SearchArgument.Builder builder = SearchArgumentFactory.newBuilder();
SearchArgument sarg =
builder.startAnd()
.between("f_bigint", PredicateLeaf.Type.LONG, 100L, 200L)
.lessThanEquals("f_int", PredicateLeaf.Type.LONG, 10L)
.end()
.build();
sarg.getLeaves()
.set(
0,
new PredicateLeafImpl(
PredicateLeaf.Operator.BETWEEN,
PredicateLeaf.Type.LONG,
"f_bigint",
null,
Collections.emptyList()));

assertExpected(sarg, BUILDER.lessOrEqual(0, 10));
}

@Test
public void testNotBetween() {
SearchArgument.Builder builder = SearchArgumentFactory.newBuilder();
Expand Down
Loading