[api] Stop reading a server error message as a format string - #9454
Merged
JingsongLi merged 1 commit intoAug 29, 2026
Merged
Conversation
plusplusjiajia
force-pushed
the
rest-error-message-not-a-format-string
branch
from
August 28, 2026 17:37
81d8362 to
6e50b82
Compare
plusplusjiajia
marked this pull request as ready for review
August 28, 2026 17:38
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
DefaultErrorHandler hands the server's error message to java.util.Formatter as syntax. When the message contains a %, the caller gets a formatting exception instead of the REST exception it waits for, and the
server's message is lost.
message: quota 80% exceeded
before : java.util.MissingFormatArgumentException: Format specifier '% e'
after : BadRequestException: quota 80% exceeded
Fixed:
super(message, args).
A sweep of every construction of these exceptions outside tests found no other site whose format argument is built from data.