Skip to content

[core]rename FileStoreCommitImpl var name #9457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 1 commit into from
Aug 29, 2026
+6 −6
Merged

[core]rename FileStoreCommitImpl var name #9457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,7 +1097,7 @@ CommitResult tryCommitOnce(
Snapshot newSnapshot;
Pair<String, Long> baseManifestList = null;
Pair<String, Long> deltaManifestList = null;
List<PartitionEntry> deltaStatistics;
List<PartitionEntry> deltaPartitionEntries;
Pair<String, Long> changelogManifestList = null;
String oldIndexManifest = null;
String indexManifest = null;
Expand Down Expand Up @@ -1173,7 +1173,7 @@ CommitResult tryCommitOnce(
long totalRecordCount = previousTotalRecordCount + deltaRecordCount;

// write new delta files into manifest files
deltaStatistics = new ArrayList<>(PartitionEntry.merge(deltaFiles));
deltaPartitionEntries = new ArrayList<>(PartitionEntry.merge(deltaFiles));
deltaManifestList = manifestList.write(manifestFile.write(deltaFiles));

// write changelog into manifest files
Expand Down Expand Up @@ -1263,7 +1263,7 @@ CommitResult tryCommitOnce(
callback ->
callback.call(finalBaseFiles, finalDeltaFiles, indexFiles, newSnapshot));
try {
success = commitSnapshotImpl(latestSnapshot, newSnapshot, deltaStatistics);
success = commitSnapshotImpl(latestSnapshot, newSnapshot, deltaPartitionEntries);
} catch (Exception e) {
// commit exception, not sure about the situation and should not clean up the files
LOG.warn(
Expand Down Expand Up @@ -1666,10 +1666,10 @@ static CoreOptions manifestCompactionOptions(
private boolean commitSnapshotImpl(
@Nullable Snapshot baseSnapshot,
Snapshot newSnapshot,
List<PartitionEntry> deltaStatistics) {
List<PartitionEntry> deltaPartitionEntries) {
try {
List<PartitionStatistics> statistics = new ArrayList<>(deltaStatistics.size());
for (PartitionEntry entry : deltaStatistics) {
List<PartitionStatistics> statistics = new ArrayList<>(deltaPartitionEntries.size());
for (PartitionEntry entry : deltaPartitionEntries) {
statistics.add(entry.toPartitionStatistics(partitionComputer));
}
return snapshotCommit.commit(
Expand Down
Loading