[common] Range-check the digit guard in DateTimeUtils

paimon-common/src/main/java/org/apache/paimon/utils/DateTimeUtils.java

@@ -349,15 +349,22 @@
                 + milli;
     }
 
+    /**
+     * Whether the string is a non-negative decimal integer that fits in an {@code int}. Callers
+     * hand the string straight to {@link Integer#parseInt}, so the range matters as much as the
+     * characters.
+     */
     private static boolean isInteger(String s) {
-        boolean isInt = s.length() > 0;
+        if (s.isEmpty() || s.length() > 10) {
+            return false;
+        }
         for (int i = 0; i < s.length(); i++) {
             if (s.charAt(i) < '0' || s.charAt(i) > '9') {
-                isInt = false;
-                break;
+                return false;
             }
         }
-        return isInt;
+        // ten digits still reach past Integer.MAX_VALUE
+        return s.length() < 10 || Long.parseLong(s) <= Integer.MAX_VALUE;
     }
 
     private static boolean isIllegalDate(int y, int m, int d) {
@@ -546,7 +553,7 @@
 
     public static Timestamp parseTimestampData(String dateStr, int precision, TimeZone timeZone)
             throws DateTimeException {
         return Timestamp.fromInstant(
                 fromTemporalAccessor(DEFAULT_TIMESTAMP_FORMATTER.parse(dateStr), precision)
                         .atZone(timeZone.toZoneId())
                         .toInstant());
@@ -625,11 +632,11 @@
     // --------------------------------------------------------------------------------------------
 
     public static Timestamp timestampToTimestampWithLocalZone(Timestamp ts, TimeZone tz) {
         return Timestamp.fromInstant(ts.toLocalDateTime().atZone(tz.toZoneId()).toInstant());
     }
 
     public static Timestamp timestampWithLocalZoneToTimestamp(Timestamp ts, TimeZone tz) {
         return Timestamp.fromLocalDateTime(LocalDateTime.ofInstant(ts.toInstant(), tz.toZoneId()));
     }
 
     public static int timestampWithLocalZoneToDate(Timestamp ts, TimeZone tz) {
@@ -645,7 +652,7 @@
     }
 
     public static Timestamp dateToTimestampWithLocalZone(int date, TimeZone tz) {
         return Timestamp.fromInstant(
                 LocalDateTime.of(toLocalDate(date), LocalTime.MIDNIGHT)
                         .atZone(tz.toZoneId())
                         .toInstant());

paimon-common/src/test/java/org/apache/paimon/utils/DateTimeUtilsTest.java

@@ -33,6 +33,24 @@
 /** Test for {@link DateTimeUtils}. */
 public class DateTimeUtilsTest {
 
+    @Test
+    public void testParseDateAndTimeOverflowReturnsNull() {
+        // A component too large for an int is an invalid date or time, not a crash: the
+        // contract of parseDate/parseTime is null for unparseable input. 2147483648 is
+        // Integer.MAX_VALUE + 1, the smallest ten-digit value that does not fit.
+        assertThat(DateTimeUtils.parseDate("2147483648-01-01")).isNull();
+        assertThat(DateTimeUtils.parseDate("2147483647-01-01"))
+                .isNull(); // in range, but not a year
+        assertThat(DateTimeUtils.parseDate("99999999999-01-01")).isNull();
+        assertThat(DateTimeUtils.parseDate("2024-99999999999-01")).isNull();
+        assertThat(DateTimeUtils.parseDate("2024-01-99999999999")).isNull();
+        assertThat(DateTimeUtils.parseTime("99999999999:00:00")).isNull();
+
+        // Sanity: valid values still parse.
+        assertThat(DateTimeUtils.parseDate("2024-01-15")).isNotNull();
+        assertThat(DateTimeUtils.parseTime("12:30:00")).isNotNull();
+    }
+
     @Test
     public void testFormatLocalDateTime() {
         LocalDateTime time = LocalDateTime.of(2023, 8, 30, 12, 30, 59, 999_999_999);