PHOENIX-7795 : Tenant TTL using Tenant Views on Multi-Tenant Table#2400
Draft
palashc wants to merge 9 commits intoapache:masterfrom
Draft
PHOENIX-7795 : Tenant TTL using Tenant Views on Multi-Tenant Table#2400palashc wants to merge 9 commits intoapache:masterfrom
palashc wants to merge 9 commits intoapache:masterfrom
Conversation
palashc
changed the title
jpisaac
reviewed
Apr 21, 2026
Contributor
jpisaac
left a comment
jpisaac
left a comment
There was a problem hiding this comment.
Looks good, Few test suggestions
| @@ -0,0 +1,520 @@ | |||
| /* | |||
Contributor
There was a problem hiding this comment.
@palashc Looks good.
Maybe add a few more test cases -
- tables with indexes,
- view with same names and diff orgs
| this.operation = operation; | ||
| } | ||
|
|
||
| public MutationPlan compile(CreateTableStatement create) throws SQLException { |
Contributor
There was a problem hiding this comment.
We should have checks for same tenant creating multiple views without where clauses.
It should not be allowed.
Contributor
Author
There was a problem hiding this comment.
@jpisaac should this check be only for tenant views on multi tenant tables or any parent?
Contributor
Author
There was a problem hiding this comment.
Added check for allowing only one tenant view without where clause on a multi tenant base table
| viewTypeToBe = visitor.isUpdatable() ? ViewType.UPDATABLE : ViewType.READ_ONLY; | ||
| boolean updatableViewRestrictionEnabled = connection.getQueryServices().getProps() | ||
| .getBoolean(PHOENIX_UPDATABLE_VIEW_RESTRICTION_ENABLED, | ||
| DEFAULT_PHOENIX_UPDATABLE_VIEW_RESTRICTION_ENABLED); |
Contributor
There was a problem hiding this comment.
Should have a test with PHOENIX_UPDATABLE_VIEW_RESTRICTION_ENABLED set to true
added 2 commits
April 21, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.