Skip to content

Fix flaky testExplainPlanQueryV2 by masking scientific-notation rule timings #18650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yashmayya wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Fix flaky testExplainPlanQueryV2 by masking scientific-notation rule timings #18650

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3569,7 +3569,7 @@ public void testExplainPlanQueryV2()
// needed because both OfflineClusterIntegrationTest and MultiNodesOfflineClusterIntegrationTest run this test
// case with different number of documents in the segment.
response1 = response1.replaceAll("docs:[0-9]+", "docs:*")
.replaceAll("Time: \\d+\\.\\d+", "Time:*");
.replaceAll("Time: \\d+\\.\\d+(?:[eE][-+]?\\d+)?", "Time:*");

JsonNode response1Json = JsonUtils.stringToJsonNode(response1);
assertEquals(response1Json.get("dataSchema").get("columnNames").get(0).asText(), "SQL");
Expand Down Expand Up @@ -3605,7 +3605,7 @@ public void testExplainPlanQueryV2()
// language=sql
String query2 = "EXPLAIN PLAN WITHOUT IMPLEMENTATION FOR SELECT * FROM mytable WHERE FlightNum < 0";
String response2 = postQuery(query2).get("resultTable").toString()
.replaceAll("Time: \\d+\\.\\d+", "Time: *");
.replaceAll("Time: \\d+\\.\\d+(?:[eE][-+]?\\d+)?", "Time: *");

JsonNode response2Json = JsonUtils.stringToJsonNode(response2);
assertEquals(response2Json.get("dataSchema").get("columnNames").get(0).asText(), "SQL");
Expand Down
Loading