Skip to content

Store numeric column min/max as primitives instead of boxed Comparables #19479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiangfu0 wants to merge 2 commits into from
+516 −71
Open

Store numeric column min/max as primitives instead of boxed Comparables #19479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a43da48
DATA-3221 (8+9): shared column shape and primitive min/max in ColumnM…
xiangfu0 Sep 6, 2026
42fc38a
DATA-3221 (8+9 follow-up): drop the shared shape, pack bitsPerElement…
xiangfu0 Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...java/org/apache/pinot/segment/local/segment/index/datasource/ImmutableDataSourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,11 @@ public void testSingleValueColumn() {
assertEquals(metadata.getNumValues(), NUM_DOCS);
assertEquals(metadata.getNumValues(), columnMetadata.getTotalNumberOfEntries());
assertEquals(metadata.getCardinality(), 37);
assertSame(metadata.getMinValue(), columnMetadata.getMinValue());
// The min/max of a fixed-width column is held as raw bits and boxed on read, so the data source view delegates
// an equal value rather than the same instance.
assertEquals(metadata.getMinValue(), columnMetadata.getMinValue());
assertEquals(metadata.getMinValue(), -5);
assertSame(metadata.getMaxValue(), columnMetadata.getMaxValue());
assertEquals(metadata.getMaxValue(), columnMetadata.getMaxValue());
assertEquals(metadata.getMaxValue(), 123456);
assertSame(metadata.getPartitionFunction(), partitionFunction);
assertSame(metadata.getPartitions(), partitions);
Expand Down
Loading
Loading