Release the classpath ResourceLoader when scomp fails - #111
Merged
Conversation
SchemaCompiler.compile builds a PathResourceLoader over the -cp entries, which opens a ZipFile per jar, and closes it on the last line of the method. Nothing guards the path in between: if loadTypeSystem, system.save(filer), generateTypes or the extension hooks throw, every classpath jar stays open for the life of the JVM. Put the body in a try/finally. The change is almost entirely re-indentation - "git diff -w" shows the try, the finally and a comment. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SchemaCompiler.compilebuilds aPathResourceLoaderover the-cpentries — which opens aZipFileper jar — and closes it on the last line of the method:Nothing guards the ~100 lines in between. If
loadTypeSystem,system.save(filer),generateTypesor the extension hooks throw, every classpath jar stays open for the life of the JVM. This is easy to hit when scomp is driven in-process (the Maven plugin, Ant task, or a build that catches the exception and carries on).The body now runs in a
try/finally. The change is almost entirely re-indentation —git diff -wshows just thetry, thefinallyand a comment.compile.scomp.checkin.CompilationTestspasses.🤖 Generated with Claude Code