Close the caller's stream when writeInputStreamToFile can't open the target - #114
Merged
Merged
Conversation
…target SchemaResourceManager.writeInputStreamToFile relies on IOUtil.copyCompletely to close both streams, but copyCompletely only runs once the target has been opened. If Files.newOutputStream throws - an unwritable directory, a path component that is not a directory, a full disk - the caller's input is never closed. Callers in BaseSchemaResourceManager pass live downloads: url.openStream(), conn.getInputStream() and the index document stream. A write failure there leaks the socket. Own the input in a try-with-resources so it is released either way. The second close on the normal path is a no-op. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SchemaResourceManager.writeInputStreamToFileleans onIOUtil.copyCompletelyto close both streams:But
copyCompletelyonly runs once the target has been opened. IfFiles.newOutputStreamthrows — an unwritable directory, a path component that is not a directory, a full disk — the caller's input is never closed.The callers in
BaseSchemaResourceManagerhand it live downloads:url.openStream()(copyOrIdentifyDuplicateURL),conn.getInputStream()(redownloadEntry) and the index document stream (writeCache). A write failure there leaks the socket, andredownloadEntry/copyOrIdentifyDuplicateURLboth justwarning(...)and carry on to the next resource, so this accumulates across a-refreshrun.The method now owns the input in a try-with-resources, so it is released either way; the second close on the normal path is a no-op.
Added
SchemaResourceManagerWriteTest, which puts a plain file where the target's parent directory should be. It fails on trunk and passes with this change.🤖 Generated with Claude Code