[fix][client] Fix incorrect topic in OTel spans for multi-topic consumers#25894
Open
void-ptr974 wants to merge 1 commit into
Open
[fix][client] Fix incorrect topic in OTel spans for multi-topic consumers#25894void-ptr974 wants to merge 1 commit into
void-ptr974 wants to merge 1 commit into
Conversation
void-ptr974
changed the title
void-ptr974
changed the title
void-ptr974
changed the title
void-ptr974
force-pushed
the
fix-otel-consumer-topic
branch
from
2f7ea38 to
08eca2b
Compare
3 tasks
void-ptr974
force-pushed
the
fix-otel-consumer-topic
branch
from
08eca2b to
39e8441
Compare
void-ptr974
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25895
Motivation
OTel consumer spans for multi-topic consumers used the internal dummy consumer topic, so traces could show span names and destination attributes like
MultiTopicsConsumer-*instead of the actual message topic.Modifications
Use the message topic when setting the consumer span destination, and keep the consumer topic only as a fallback for messages or callbacks that do not carry a topic.
Verifications
./gradlew :pulsar-client-original:compileJava./gradlew :pulsar-broker:test --tests org.apache.pulsar.broker.service.OpenTelemetryTracingIntegrationTest.testMultiTopicConsumerTracing