[fix][meta] Fix PulsarZooKeeperClient async addWatch callback retry behavior#25913
Open
oneby-wang wants to merge 1 commit into
Open
[fix][meta] Fix PulsarZooKeeperClient async addWatch callback retry behavior#25913oneby-wang wants to merge 1 commit into
oneby-wang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The async ZooKeeper addWatch wrapper in PulsarZooKeeperClient defined a retry callback but delegated the operation using the original callback and context. If addWatch returned a recoverable error, the caller could observe the transient failure directly instead of retrying. The wrapper's completion branch also recursively invoked itself, which would be incorrect if the wrapper callback were used.
This affects the SessionReestablished path in ZKMetadataStore, where Pulsar recreates the persistent recursive watch before notifying session listeners.
Modifications
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts: