Add Node.js runtime metrics analyzer and E2E coverage#13930
Open
songzhendong wants to merge 1 commit into
Open
Add Node.js runtime metrics analyzer and E2E coverage#13930songzhendong wants to merge 1 commit into
songzhendong wants to merge 1 commit into
Conversation
Add nodejs-runtime MAL rules, documentation, e2e assertions, and pin SW_AGENT_NODEJS_COMMIT to apache/skywalking-nodejs master @ 36df516 (merged apache/skywalking-nodejs#139).
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add OAP-side support for Node.js runtime metrics reported by
MeterReportServicefrom skywalking-nodejs (commit36df516).Changes
nodejs-runtime.yamlMAL analyzer with 6 rules →meter_instance_nodejs_*:process_cpu,heap_used,heap_total,heap_limit,rss,external_memoryapplication.yml; add unit test data (nodejs-runtime.data.yaml)test/e2e-v2/cases/nodejs/e2e.yaml)dashboards-nodejs-runtime.md), menu entry, andchanges.mdRelated PRs
CI (fork validation)
CI(skywalking.yaml)Dead Link CheckerCINode.js E2E jobs in the OAP CI run:
Agent NodeJS Backend,Agent NodeJS Frontend,Agent NodeJS Frontend ES,Agent NodeJS Frontend ES Sharding,Meter— all passed.Test plan
nodejs-runtime.data.yamlMAL rulesAgent NodeJS Backend/Frontendjobs assert 6meter_instance_nodejs_*metrics