SOLR-18233 Fix test failure in AuthToolTest#4520
Open
janhoy wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
One possible issue with enforcing this check is that existing installs may have custom users with user==pass already, and they would need to change their password before upgrade to avoid being locked out from their user account. Perhaps not a major risk, as this will be caught early on in testing. But it is for sure a back-compat break (in the name of security) that will affect users. So they may need to reset user passwords directly in zookeeper or with a super-user account that is not locked out. |
epugh
approved these changes
Jun 10, 2026
epugh
left a comment
epugh
left a comment
Contributor
There was a problem hiding this comment.
Lgtm. I am glad the classic solrRocks password matches our tighter rules still!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18233
Fix silly test failure not caught in the first merge. Since username==password is no longer accepted, the test using
solr:solrnow fails.