SOLR-18300 : Update apache.kafka to V4 #4610
+227
−1,493
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| title: Update apache.kafka to v4 | ||
| type: dependency_update | ||
| authors: | ||
| - name: Jalaz Kumar | ||
| - name: Eric Pugh | ||
| links: | ||
| - name: SOLR-18300 | ||
| url: https://issues.apache.org/jira/browse/SOLR-18300 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
|
|
@@ -40,8 +38,6 @@ dependencies { | |
| runtimeOnly libs.commonscodec.commonscodec | ||
|
|
||
| implementation libs.apache.kafka.clients | ||
|
|
||
| runtimeOnly libs.apache.log4j.api | ||
| runtimeOnly libs.apache.log4j.core | ||
|
|
@@ -65,35 +61,17 @@ dependencies { | |
| testRuntimeOnly libs.bytebuddy | ||
| testRuntimeOnly libs.bytebuddy.agent | ||
|
|
||
| testImplementation libs.testcontainers.kafka | ||
| } | ||
|
|
||
| ext { | ||
| mainClass = 'org.apache.solr.crossdc.manager.consumer.Consumer' | ||
|
|
||
| // Docker/Testcontainers integration tests (KafkaContainerRule) do PATH scanning, | ||
| // spawn processes, and talk to the Docker daemon over a Unix socket -- none of | ||
| // which play well with a static SecurityManager policy. Same rationale as | ||
| // solr:modules:extraction, Solr's other Testcontainers consumer. | ||
| useSecurityManager = false | ||
|
Comment on lines
+70
to
+74
Contributor
Author
There was a problem hiding this comment. this is great! 💯 verified this working fine on local here: #4610 (comment) |
||
| } | ||
|
|
||
| task run(type: JavaExec) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,7 +88,8 @@ public static void printKafkaInfo(String host, String groupId) { | |
| for (TopicPartition topicPartition : topicPartitions) { | ||
| if (topicPartition.topic().equals(topic)) { | ||
| long endOffset = consumer.position(topicPartition); | ||
|
Contributor
Author
There was a problem hiding this comment. https://github.com/apache/solr/actions/runs/28428066221/job/84235821648 , Simply updating the version was giving compilation error. 
Evidences for supporting this change:
Contributor
There was a problem hiding this comment. I guess this is one of those deprecated apis that I saw now being fixed! |
||
| long committedOffset = | ||
| consumer.committed(Set.of(topicPartition)).get(topicPartition).offset(); | ||
| long updatesInQueue = endOffset - committedOffset; | ||
|
|
||
| log.info("Topic: {}", topic); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.