SOLR-18381: remove ClusterState.getReplicaNamesPerCollectionOnNode, un-deprecate createFromCollectionMap - #4768
Open
serhiy-bzhezytskyy wants to merge 1 commit into
Conversation
…n-deprecate createFromCollectionMap getReplicaNamesPerCollectionOnNode had 0 remaining callers after migrating ZkController/ZkControllerTest to collectionStream() + getReplicasOnNode. createFromCollectionMap is un-deprecated instead of removed, contrary to the ticket's title: it's still called from createFromJson (deprecated, tracked separately in the still-open SOLR-18149) plus two production call sites. AI-assisted (Claude Sonnet 5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18381
Removes
ClusterState.getReplicaNamesPerCollectionOnNode(0 callers left after migratingZkController/ZkControllerTesttocollectionStream()+getReplicasOnNode), and un-deprecatescreateFromCollectionMapinstead of removing it as the title suggests -- it's still called fromcreateFromJson(deprecated, tracked separately in the still-open SOLR-18149) plus two production call sites.14 tests, 0 failures.
SOLR-18370 (local, not yet a PR) also touches ZkController.java, different region -- re-check once it opens a PR.
AI-assisted (Claude Sonnet 5)