Skip to content

SOLR-18385: remove CollectionAdminRequest.PROPERTY_PREFIX #4770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epugh merged 1 commit into from
Aug 20, 2026
Merged

SOLR-18385: remove CollectionAdminRequest.PROPERTY_PREFIX #4770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog/unreleased/SOLR-18385-remove-collectionadminrequest-property-prefix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc
title: Remove the deprecated CollectionAdminRequest.PROPERTY_PREFIX field, which was only an alias - use CollectionAdminParams.PROPERTY_PREFIX instead.
type: removed
authors:
- name: Serhiy Bzhezytskyy
links:
- name: SOLR-18385
url: https://issues.apache.org/jira/browse/SOLR-18385
2 changes: 1 addition & 1 deletion dev-docs/overseer/overseer.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ Note that properties `"parent"`, `"shard_parent_zk_session"` and `"shard_parent_

deleteShard() (implementing `CollectionAction.DELETESHARD`) removes a slice (shard) from a collection.

modifyCollection() (implementing `CollectionAction.MODIFYCOLLECTION`) modifies a given collection by setting new values for (or removing) specified properties, ignoring changes to properties that are not considered modifiable (those listed in `CollectionAdminRequest.MODIFIABLE_COLLECTION_PROPERTIES` and those starting with `CollectionAdminRequest.PROPERTY_PREFIX="property."`).
modifyCollection() (implementing `CollectionAction.MODIFYCOLLECTION`) modifies a given collection by setting new values for (or removing) specified properties, ignoring changes to properties that are not considered modifiable (those listed in `CollectionAdminRequest.MODIFIABLE_COLLECTION_PROPERTIES` and those starting with `CollectionAdminParams.PROPERTY_PREFIX="property."`).

updateSlice() replaces a `Slice` on an existing `DocCollection` or creates a new `DocCollection` with the provided slice.

Expand Down
3 changes: 1 addition & 2 deletions solr/core/src/java/org/apache/solr/cloud/api/collections/ReindexCollectionCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
import org.apache.solr.client.solrj.SolrRequest;
import org.apache.solr.client.solrj.SolrResponse;
import org.apache.solr.client.solrj.cloud.DistribStateManager;
import org.apache.solr.client.solrj.request.CollectionAdminRequest;
import org.apache.solr.client.solrj.request.GenericSolrRequest;
import org.apache.solr.client.solrj.request.QueryRequest;
import org.apache.solr.client.solrj.response.QueryResponse;
Expand Down Expand Up @@ -98,7 +97,7 @@ public class ReindexCollectionCmd implements CollApiCmds.CollectionApiCommand {
public static final String TARGET = "target";
public static final String TARGET_COL_PREFIX = ".rx_";
public static final String CHK_COL_PREFIX = ".rx_ck_";
public static final String REINDEXING_STATE = CollectionAdminRequest.PROPERTY_PREFIX + "rx";
public static final String REINDEXING_STATE = CollectionAdminParams.PROPERTY_PREFIX + "rx";

public static final String STATE = "state";
public static final String PHASE = "phase";
Expand Down
3 changes: 2 additions & 1 deletion solr/core/src/java/org/apache/solr/cloud/overseer/CollectionMutator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import org.apache.solr.common.cloud.SolrZkClient;
import org.apache.solr.common.cloud.ZkNodeProps;
import org.apache.solr.common.cloud.ZkStateReader;
import org.apache.solr.common.params.CollectionAdminParams;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down Expand Up @@ -154,7 +155,7 @@ public ZkWriteCommand modifyCollection(final ClusterState clusterState, ZkNodePr
}
// other aux properties are also modifiable
for (String prop : message.keySet()) {
if (prop.startsWith(CollectionAdminRequest.PROPERTY_PREFIX)) {
if (prop.startsWith(CollectionAdminParams.PROPERTY_PREFIX)) {
hasAnyOps = true;
if (message.get(prop) == null) {
props.remove(prop);
Expand Down
3 changes: 1 addition & 2 deletions solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import static org.apache.solr.common.params.CollectionAdminParams.COUNT_PROP;
import static org.apache.solr.common.params.CollectionAdminParams.CREATE_NODE_SET_PARAM;
import static org.apache.solr.common.params.CollectionAdminParams.CREATE_NODE_SET_SHUFFLE_PARAM;
import static org.apache.solr.common.params.CollectionAdminParams.PROPERTY_PREFIX;
import static org.apache.solr.common.params.CollectionAdminParams.ROUTER_PREFIX;
import static org.apache.solr.common.params.CollectionAdminParams.SKIP_NODE_ASSIGNMENT;
import static org.apache.solr.common.params.CoreAdminParams.BACKUP_REPOSITORY;
Expand Down Expand Up @@ -77,8 +78,6 @@ public abstract class CollectionAdminRequest<T extends CollectionAdminResponse>

protected final CollectionAction action;

@Deprecated public static String PROPERTY_PREFIX = CollectionAdminParams.PROPERTY_PREFIX;

public CollectionAdminRequest(CollectionAction action) {
this("/admin/collections", action);
}
Expand Down
Loading