[SPARK-56426][SQL] Fix LATERAL VIEW column alias with dot in name#55282
Open
jiwen624 wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-56426][SQL] Fix LATERAL VIEW column alias with dot in name#55282jiwen624 wants to merge 1 commit intoapache:masterfrom
jiwen624 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@cloud-fan @dongjoon-hyun could you take a look at this bug fix when you get a chance? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
ResolveGenerate, generator output column names were extracted viaUnresolvedAttribute.name, which wraps any name containing a dot in backtick characters (e.g."skill.inst"→"`skill.inst`"). This string was then passed directly tomakeGeneratorOutputas the resolved attribute name, embedding literal backtick characters into the column name.The fix uses
nameParts.headinstead, which returns the raw identifier text without display-formatting.Why are the changes needed?
Using a backtick-quoted identifier with a dot as a
LATERAL VIEWcolumn alias causes anUNRESOLVED_COLUMNerror at analysis time:The triple-backtick suggestion reveals that the resolved attribute name contains literal backtick characters, caused by
UnresolvedAttribute.namebeing misused as a raw identifier extractor rather than for display only.This worked in Spark 3.1.x.
Does this PR introduce any user-facing change?
Yes. Queries using a backtick-quoted
LATERAL VIEWcolumn alias containing a dot (e.g.`a.b`) now execute correctly instead of failing withUNRESOLVED_COLUMN.How was this patch tested?
Added a test case in
SQLQuerySuitecoveringLATERAL VIEWwith a dot-containing column alias.Was this patch authored or co-authored using generative AI tooling?
No.