Skip to content

[SPARK-57254][INFRA] Put CI-unrelated files in a module so CI won't be triggered#56312

Open
gaogaotiantian wants to merge 1 commit into
apache:masterfrom
gaogaotiantian:ignore-some-files
Open

[SPARK-57254][INFRA] Put CI-unrelated files in a module so CI won't be triggered#56312
gaogaotiantian wants to merge 1 commit into
apache:masterfrom
gaogaotiantian:ignore-some-files

Conversation

@gaogaotiantian
Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Put all the CI-unrelated files in a module called dev-tools so they are correctly categorized - then they won't be considered part of "root" module and trigger a full CI.

Notice that lint workflow is not impacted because it does not check changed files.

Why are the changes needed?

To reduce CI usage. According to Claude Code estimation, we could skip about 70 commits in the past year (2% of all commits).

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

Was this patch authored or co-authored using generative AI tooling?

No.

"dev/lint-scala",
"dev/reformat-python",
"dev/structured_logging_style.py",
"dev/merge_spark_pr.py",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually have unittests in this script. Shouldn't we run it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we currently run the unittests (doctest) in this file in our CI. Maybe we should do it, but this PR has no impact to the current situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants