Skip to content

[SPARK-56413][UDF][BUILD][FOLLOWUP] Fix parent POM version in udf-worker-grpc module on branch-4.x #56325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cloud-fan wants to merge 1 commit into from
+1 −1
Closed

[SPARK-56413][UDF][BUILD][FOLLOWUP] Fix parent POM version in udf-worker-grpc module on branch-4.x #56325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion udf/worker/grpc/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<parent>
<groupId>org.apache.spark</groupId>
<artifactId>spark-parent_2.13</artifactId>
<version>5.0.0-SNAPSHOT</version>
<version>4.2.0-SNAPSHOT</version>
Copy link
Copy Markdown
Contributor

@zhengruifeng zhengruifeng Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 4.3.0 in branch-4.x?

Copy link
Copy Markdown
Contributor

@haiyangsun-db haiyangsun-db Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing, I think @zhengruifeng is right that this was newly introduced recently in spark 4.x (after 4.2 cut).

Copy link
Copy Markdown
Contributor Author

@cloud-fan cloud-fan Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parent version has to match the root pom.xml, and branch-4.x is currently on 4.2.0-SNAPSHOT (not 4.3.0 yet), so 4.2.0-SNAPSHOT is the correct value here. This was the actual bug — the module had 5.0.0-SNAPSHOT (master's version) leaking onto the branch.

That said, you have a point that the branch version looks stale — we should likely bump branch-4.x to 4.3.0-SNAPSHOT in a separate change. But that's a branch-wide version bump (root POM + all modules), so it's out of scope for this fix.

<relativePath>../../../pom.xml</relativePath>
</parent>

Expand Down