[SPARK-57277][INFRA] Prefix all CI cache keys with runner.os#56342
Open
zhengruifeng wants to merge 1 commit into
Open
[SPARK-57277][INFRA] Prefix all CI cache keys with runner.os#56342zhengruifeng wants to merge 1 commit into
runner.os#56342zhengruifeng wants to merge 1 commit into
Conversation
Add \${{ runner.os }}- as a prefix to every cache key and restore-key
value in CI workflows that lacked it, so caches are isolated per OS and
never cross-pollute between Linux and Windows runners.
Generated-by: Claude Sonnet 4.6
zhengruifeng
changed the title
runner.os
zhengruifeng
changed the title
runner.osrunner.os
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
${{ runner.os }}-as a prefix to every cachekey:andrestore-keys:value in all CI workflow files that did not already have it:build_and_test.yml:build-,docs-maven-,tpcds-build_sparkr_window.yml:build-sparkr-windows-maven-maven_test.yml:build-,java${{...}}-maven-build_python_connect.yml/build_python_connect40.yml:build-spark-connect-python-only-,coursier-build-spark-connect-python-only-python_hosted_runner_test.yml:build-publish_snapshot.yml:snapshot-maven-Keys that already carried the
${{ runner.os }}-prefix (e.g.${{ runner.os }}-coursier-) are unchanged.Why are the changes needed?
Without an OS prefix, cache entries from Linux, macOS, and Windows runners share the same key namespace. A cache written by one OS can be restored on another, causing subtle build failures or stale-artifact issues. Prefixing with
${{ runner.os }}ensures each OS has its own isolated cache.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI workflow change only; no code logic changed. The cache keys are verified by inspection.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Sonnet 4.6