[SPARK-58204][SQL] Fix unprotected mutable state in RegExpReplace, RegExpExtractBase, StringTranslate, FormatNumber, and NamedLambdaVariable by marking them stateful#57353
Open
vinodkc wants to merge 1 commit into
Conversation
…gExpExtractBase, StringTranslate, FormatNumber, and NamedLambdaVariable by marking them stateful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Override
stateful: Boolean = trueon five Catalyst expressions that maintain mutable@transientstate but were not marked stateful:RegExpReplaceRegExpExtractBase(RegExpExtract,RegExpExtractAll)StringTranslateFormatNumberNamedLambdaVariableFor
NamedLambdaVariable, also overridewithNewChildrenInternalto reset theAtomicReferenceon copy while preservingexprId.LeafLike.withNewChildrenInternalreturnsthisby default, which would makefreshCopyIfContainsStatefulExpression()a no-op even with thestatefulflag set.Why are the changes needed?
freshCopyIfContainsStatefulExpression()only copies subtrees containing astateful = truenode. Without the override, these expressions are shared across projections. When two projections evaluate concurrently — e.g. viaConvertToLocalRelationon the driver or pipelined execution on executors — threads race on the shared@transientcache fields and silently corrupt results.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added one test per affected group in the existing suites (
HigherOrderFunctionsSuite,RegexpExpressionsSuite,StringExpressionsSuite), each assertingstateful == trueand thatfreshCopyIfContainsStatefulExpression()returns a distinct instance with independent state.Was this patch authored or co-authored using generative AI tooling?
No