STORM-8585: Sync checkstyle config with upstream google_checks.xml

THIRD-PARTY.properties

@@ -32,4 +32,4 @@ javax.servlet--servlet-api--2.5=COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDD
 javax.servlet.jsp--jsp-api--2.1=COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.1
 javax.transaction--jta--1.1=COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.1
 javax.transaction--transaction-api--1.1=COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.1
-org.glassfish.jersey--jersey-bom--2.27=COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.1
+org.glassfish.jersey--jersey-bom--2.27=COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.1

examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/OutputStreamEngine.java

@@ -119,4 +119,4 @@ public String nextKey() {
     public int nextInt(int bound) {
         return rand.nextInt(bound);
     }
-}
+}

examples/storm-perf/src/main/java/org/apache/storm/perf/queuetest/Producer2.java

@@ -47,4 +47,4 @@ public void run() {
         }
 
     }
-}
+}

examples/storm-perf/src/main/java/org/apache/storm/perf/toolstest/Prod.java

@@ -43,4 +43,4 @@ public void run() {
         runTime = System.currentTimeMillis() - start;
     }
 
-}
+}

examples/storm-starter/src/jvm/org/apache/storm/starter/MultiThreadWordCountTopology.java

@@ -104,4 +104,4 @@ public Map<String, Object> getComponentConfiguration() {
         public void cleanup() {
         }
     }
-}
+}

external/storm-autocreds/src/main/java/org/apache/storm/common/AbstractHadoopAutoCreds.java

@@ -147,4 +147,4 @@ private void loadConfigKeys(Map<String, Object> conf) {
         }
     }
 
-}
+}

external/storm-autocreds/src/main/java/org/apache/storm/hdfs/security/HdfsSecurityUtil.java

@@ -73,4 +73,4 @@ public static void login(Map<String, Object> conf, Configuration hdfsConfig) thr
             }
         }
     }
-}
+}

external/storm-hdfs/src/test/resources/log4j.properties

@@ -20,4 +20,4 @@ log4j.rootLogger = WARN, out
 
 log4j.appender.out = org.apache.log4j.ConsoleAppender
 log4j.appender.out.layout = org.apache.log4j.PatternLayout
-log4j.appender.out.layout.ConversionPattern = %d (%t) [%p - %l] %m%n
+log4j.appender.out.layout.ConversionPattern = %d (%t) [%p - %l] %m%n

external/storm-jms/src/test/resources/jndi.properties

@@ -15,4 +15,4 @@
 # limitations under the License.
 
 java.naming.factory.initial = org.apache.activemq.jndi.ActiveMQInitialContextFactory
-java.naming.provider.url = vm://localhost?broker.persistent=false
+java.naming.provider.url = vm://localhost?broker.persistent=false

external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaPartitionOffsetLag.java

@@ -1,4 +1,4 @@
-/*******************************************************************************
+/*
  * Licensed to the Apache Software Foundation (ASF) under one
  * or more contributor license agreements.  See the NOTICE file
  * distributed with this work for additional information
@@ -14,7 +14,7 @@
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  * See the License for the specific language governing permissions and
  * limitations under the License.
- *******************************************************************************/
+ */
 
 package org.apache.storm.kafka.monitor;
 

flux/flux-core/src/test/resources/configs/test.properties

@@ -16,4 +16,4 @@
 
 topology.name: substitution-topology
 a.list.property: ["A string list"]
-some.other.property: foo bar
+some.other.property: foo bar

flux/flux-examples/src/main/resources/hbase_bolt.properties

@@ -15,4 +15,4 @@
 # limitations under the License.
 
 hbase.rootdir=hdfs://hadoop:54310/hbase
-hbase.zookeeper.quorum=hadoop
+hbase.zookeeper.quorum=hadoop

flux/flux-examples/src/main/resources/hdfs_bolt.properties

@@ -23,4 +23,4 @@ hdfs.write.dir=/incoming
 
 # The HDFS directory where files will be moved once the bolt has
 # finished writing to it.
-hdfs.dest.dir=/complete
+hdfs.dest.dir=/complete

integration-test/src/main/java/org/apache/storm/st/topology/window/TimeDataVerificationBolt.java

@@ -66,4 +66,4 @@ public void execute(TupleWindow inputWindow) {
     public void declareOutputFields(OutputFieldsDeclarer declarer) {
         declarer.declare(new Fields(DUMMY_FIELD));
     }
-}
+}

storm-checkstyle/src/main/resources/storm/storm_checkstyle.xml

@@ -70,6 +70,8 @@
         <property name="eachLine" value="true"/>
     </module>
 
+    <module name="NewlineAtEndOfFile"/>
+
     <module name="LineLength">
         <property name="fileExtensions" value="java"/>
         <property name="max" value="100"/>
@@ -84,7 +86,7 @@
         <property name="onCommentFormat" value='^\s*"""\s*(?:[,;]|.+)$'/>
     </module>
     <module name="SuppressWithPlainTextCommentFilter">
-        <property name="checkFormat" value="IndentationCheck"/>
+        <property name="checkFormat" value="\.IndentationCheck$"/>
         <property name="offCommentFormat" value='^""".?'/>
         <property name="onCommentFormat" value='.'/>
     </module>
@@ -409,13 +411,20 @@
                     RECORD_DEF, RECORD_PATTERN_DEF"/>
         </module>
         <module name="OperatorWrap">
+            <property name="id" value="OperatorWrapNL"/>
             <property name="option" value="NL"/>
             <property name="tokens"
                       value="BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR,
                     LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR, METHOD_REF,
                     TYPE_EXTENSION_AND "/>
             <property name="severity" value="warning"/>
         </module>
+        <module name="OperatorWrap">
+            <property name="id" value="OperatorWrapEOL"/>
+            <property name="option" value="EOL"/>
+            <property name="tokens" value="LAMBDA"/>
+            <property name="severity" value="warning"/>
+        </module>
         <module name="AnnotationLocation">
             <property name="id" value="AnnotationLocationTypeAndPackage"/>
             <property name="tokens"
@@ -505,10 +514,17 @@
             <property name="severity" value="warning"/>
         </module>
         <module name="TodoComment">
+            <property name="id" value="TodoFormat"/>
             <property name="format" value="^[ \t]*(?!TODO:)(?i:TODO)\b:?"/>
             <message key="todo.match"
                      value="''TODO:'' must be written in all caps and followed by a colon."/>
         </module>
+        <module name="TodoComment">
+            <property name="id" value="BoxComments"/>
+            <property name="format" value="^[ \t]*([*=#])\1{8,}[ \t]*$"/>
+            <message key="todo.match"
+                     value="Comment uses box-like repetitive character pattern."/>
+        </module>
         <module name="EmptyCatchBlock">
             <property name="commentFormat" value="\w+"/>
         </module>
@@ -535,4 +551,4 @@
             <property name="influenceFormat" value="1"/>
         </module>
     </module>
-</module>
+</module>

storm-client/src/jvm/org/apache/storm/blobstore/LocalModeClientBlobStore.java

@@ -129,4 +129,4 @@ public void close() {
     public long getRemoteBlobstoreUpdateTime() throws IOException {
         return -1L; // not supported
     }
-}
+}

storm-client/src/jvm/org/apache/storm/daemon/worker/WorkerTransfer.java

@@ -141,4 +141,4 @@ public void haltTransferThd() {
         transferQueue.close();
     }
 
-}
+}

storm-client/src/jvm/org/apache/storm/executor/Executor.java

@@ -724,9 +724,7 @@ private Map<String, Map<String, LoadAwareCustomStreamGrouping>> outboundComponen
         return ret;
     }
 
-    // =============================================================================
-    // ============================ getter methods =================================
-    // =============================================================================
+    // getter methods
 
     private Map<String, Object> normalizedComponentConf(
         Map<String, Object> topoConf, WorkerTopologyContext topologyContext, String componentId) {

storm-client/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java

@@ -361,4 +361,4 @@ void resetWeight() {
             weight = MAX_WEIGHT;
         }
     }
-}
+}

storm-client/src/jvm/org/apache/storm/grouping/PartialKeyGrouping.java

@@ -126,9 +126,7 @@ private byte[] getKeyBytes(List<Object> values) {
         return raw;
     }
 
-    /*==================================================
-     * Helper Classes
-     *==================================================*/
+    // Helper Classes
 
     /**
      * This interface is responsible for choosing a subset of the target tasks to use for a given key.
@@ -196,4 +194,4 @@ public Integer chooseTask(int[] assignedTasks) {
             return taskIdWithMinLoad;
         }
     }
-}
+}

storm-client/src/jvm/org/apache/storm/messaging/netty/MessageDecoder.java

@@ -173,4 +173,4 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
         LOG.error("Exception thrown while decoding messages in channel {}; exception: ", ctx.channel(), cause);
         ctx.close();
     }
-}
+}

storm-client/src/jvm/org/apache/storm/metric/cgroup/CGroupCpuGuaranteeByCfsQuota.java

@@ -50,4 +50,4 @@ public Long getDataFrom(CgroupCore core) throws IOException {
         previousTime = now;
         return msGuarantee;
     }
-}
+}

storm-client/src/jvm/org/apache/storm/metric/cgroup/CGroupMetricsBase.java

@@ -119,4 +119,4 @@ public Object getValueAndReset() {
     }
 
     public abstract T getDataFrom(CgroupCore core) throws Exception;
-}
+}

storm-client/src/jvm/org/apache/storm/metrics2/DimensionalReporter.java

@@ -94,4 +94,4 @@ public interface DimensionHandler {
          */
         void setDimensions(Map<String, String> dimensions);
     }
-}
+}

storm-client/src/jvm/org/apache/storm/metrics2/TaskMetricDimensions.java

@@ -68,4 +68,4 @@ public boolean equals(Object o) {
     public int hashCode() {
         return taskId + componentId.hashCode() + streamId.hashCode();
     }
-}
+}

storm-client/src/jvm/org/apache/storm/metrics2/TaskMetricRepo.java

@@ -100,4 +100,4 @@ void degister(MetricFilter metricFilter) {
         meters.entrySet().removeIf(entry -> metricFilter.matches(entry.getKey(), entry.getValue()));
         timers.entrySet().removeIf(entry -> metricFilter.matches(entry.getKey(), entry.getValue()));
     }
-}
+}

storm-client/src/jvm/org/apache/storm/metrics2/cgroup/CGroupCpu.java

@@ -77,4 +77,4 @@ private synchronized int getUserHz() throws IOException {
         }
         return userHz;
     }
-}
+}

storm-client/src/jvm/org/apache/storm/metrics2/reporters/ConsoleStormReporter.java

@@ -107,4 +107,4 @@ public void setDimensions(Map<String, String> dimensions) {
     public void close() throws IOException {
         super.close();
     }
-}
+}

storm-client/src/jvm/org/apache/storm/metrics2/reporters/CsvStormReporter.java

@@ -93,4 +93,4 @@ public void prepare(MetricRegistry metricsRegistry, Map<String, Object> topoConf
     public void close() throws IOException {
         super.close();
     }
-}
+}

storm-client/src/jvm/org/apache/storm/metrics2/reporters/GraphiteStormReporter.java

@@ -99,4 +99,4 @@ public void prepare(MetricRegistry metricsRegistry, Map<String, Object> topoConf
     public void close() throws IOException {
         super.close();
     }
-}
+}

storm-client/src/jvm/org/apache/storm/metrics2/reporters/JmxStormReporter.java

@@ -92,4 +92,4 @@ public void close() throws IOException {
             reporter.close();
         }
     }
-}
+}

storm-client/src/jvm/org/apache/storm/metrics2/reporters/StormReporter.java

@@ -34,4 +34,4 @@ default void prepare(MetricRegistryProvider metricRegistryProvider, Map<String,
     void start();
 
     void stop();
-}
+}

storm-client/src/jvm/org/apache/storm/security/auth/X509CertPrincipalToLocal.java

@@ -70,4 +70,4 @@ public String toLocal(String principalName) {
     }
 
 
-}
+}

storm-client/src/jvm/org/apache/storm/security/auth/authorizer/SupervisorSimpleACLAuthorizer.java

@@ -151,4 +151,4 @@ private Boolean checkUserGroupAllowed(Set<String> userGroups, Set<String> config
         }
         return false;
     }
-}
+}

storm-client/src/jvm/org/apache/storm/security/auth/sasl/SimpleSaslClientCallbackHandler.java

@@ -69,4 +69,4 @@ public void handle(Callback[] callbacks) throws UnsupportedCallbackException {
             }
         }
     }
-}
+}

storm-client/src/jvm/org/apache/storm/security/auth/tls/ReloadableX509KeyManager.java

@@ -133,4 +133,4 @@ public KeyStore getKeyStore(String keystorePath, String keystorePassword) throws
         }
         return keystore;
     }
-}
+}

storm-client/src/jvm/org/apache/storm/security/auth/tls/ReloadableX509TrustManager.java

@@ -114,4 +114,4 @@ private synchronized void reloadCert(String trustStorePath, String keystorePassw
         }
     }
 
-}
+}

storm-client/src/jvm/org/apache/storm/stats/ClientStatsUtil.java

@@ -168,9 +168,7 @@ public static <K1, K2> Map windowSetConverter(
         return ret;
     }
 
-    // =====================================================================================
     // key transformers
-    // =====================================================================================
 
     /**
      * Provides a way to transform one key into another.

storm-client/src/jvm/org/apache/storm/utils/DRPCClient.java

@@ -145,4 +145,4 @@ public void close() throws Exception {
             localOverrideClient = null;
         }
     }
-}
+}

storm-client/src/jvm/org/apache/storm/utils/DefaultShellLogHandler.java

@@ -97,4 +97,4 @@ public void log(final ShellMsg shellMsg) {
                 break;
         }
     }
-}
+}

storm-client/src/jvm/org/apache/storm/utils/JCQueue.java

@@ -582,4 +582,4 @@ void afterFlush(boolean wasFull) {
             }
         }
     }
-}
+}

storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java

@@ -37,4 +37,4 @@ void setUpContext(Class<?> ownerCls, ShellProcess process,
      * @param msg - the {@link ShellMsg} containing the message to log.
      */
     void log(ShellMsg msg);
-}
+}

storm-client/test/resources/storm-core-version-info.properties

@@ -20,4 +20,4 @@ branch=not-a-real-branch
 date=today
 user=me
 url=https://storm.apache.org/
-srcChecksum=0
+srcChecksum=0

storm-core/src/jvm/org/apache/storm/command/ShellSubmission.java

@@ -43,4 +43,4 @@ public static void main(String[] args) throws Exception {
             ServerUtils.execCommand(newArgs);
         }
     }
-}
+}

storm-server/src/main/java/org/apache/storm/container/docker/DockerCommand.java

@@ -48,4 +48,4 @@ protected final void addCommandArguments(String... arguments) {
     public String getCommandWithArguments() {
         return StringUtils.join(commandWithArguments, " ");
     }
-}
+}