chore: drop legacy /superset prefix from remaining hardcoded URLs#42156
Open
sadpandajoe wants to merge 1 commit into
Open
chore: drop legacy /superset prefix from remaining hardcoded URLs#42156sadpandajoe wants to merge 1 commit into
sadpandajoe wants to merge 1 commit into
Conversation
Following #39925, which collapsed the historical `/superset/` prefix off all canonical views, a few hardcoded literals still emit the old form and rely on the closed-set 308 redirect shim (scheduled for removal at EOL 5.0.0). Point them at the canonical paths directly: - deck.gl and legacy nvd3 `getURIDirectory()`: `/superset/explore_json/` -> `/explore_json/` - filter-box -> native-filter migration markdown href: `/superset/slice/{id}/` -> `/slice/{id}/` The migration-helper change only affects future upgrade runs; markdown already written to migrated dashboards is untouched (and still shim-covered until 5.0.0). No tests pin these literals, and `/explore_json/` and `/slice/<int>/` are live routes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sadpandajoe
requested review from
betodealmeida,
eschutho,
michael-s-molina and
mistercrunch
as code owners
July 18, 2026 02:08
dosubot
Bot
added
change:frontend
Contributor
Code Review Agent Run #ca156dActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
github-actions
Bot
added
risk:db-migration
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #42156 +/- ##
==========================================
+ Coverage 64.49% 64.94% +0.44%
==========================================
Files 2747 2756 +9
Lines 153977 155047 +1070
Branches 35318 35476 +158
==========================================
+ Hits 99315 100689 +1374
+ Misses 52751 52443 -308
- Partials 1911 1915 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Following #39925, which collapsed the historical
/superset/prefix off allcanonical views (
Superset.route_base = ""), a few hardcoded URL literals stillemit the old
/superset/...form and rely on the closed-set 308 redirect shim(scheduled for removal at EOL 5.0.0). This points them at the canonical paths
directly so they no longer depend on the shim:
getURIDirectory()in the deck.gl and legacy nvd3 chart plugins:/superset/explore_json/→/explore_json//superset/slice/{id}/→/slice/{id}/The migration-helper change only affects future upgrade runs — markdown already
written to previously-migrated dashboards is untouched (and remains shim-covered
until 5.0.0). No new migration is introduced; this only edits shared helper text.
/explore_json/and/slice/<int>/are both live routes on master.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — internal URL construction; no visual change.
TESTING INSTRUCTIONS
/explore_json/...directly (no/superset/prefix, no 308 redirect hop).filter-box chart; confirm the generated markdown links to
/slice/<id>/.ADDITIONAL INFORMATION