chore(build): remove legacy re-export shim used for development

[hainenber]

chore(build): remove legacy shim of hacked re-export used for development

SUMMARY

Cleaning up of hack-ish shim used for development in the past. I tried running npm run dev without these shims, all works well with modern tooling.

I tried to gauge more contexts from the original PR but sadly, GitHub failed to render the content :(

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

1. Run npm run dev
2. Perform a few smoke tests

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #d3d7fc

Actionable Suggestions - 0

Additional Suggestions - 2

• superset-frontend/plugins/plugin-chart-ag-grid-table/src/index.ts - 1

  • Orphaned comment after hack removal · Line 35-35
    Consider removing or updating the comment at lines 34-35. The comment 'must export something for the module to exist in dev mode' now describes behavior that no longer exists. Since `export * from './types'` properly exports all named exports, this comment is misleading and should be removed or updated to explain the actual export pattern.
• superset-frontend/packages/superset-ui-core/src/query/api/legacy/index.ts - 1

  • Dead export removal safe · Line 24-24
    The removed line exported `types` module as a named export `__hack_reexport_query_api_legacy`, which is redundant because line 23 already contains `export * from './types'`. This export was never imported anywhere in the codebase (verified via cross-repo search). Removal has no functional impact.

Review Details

• Files reviewed - 30 · Commit Range: 62ff652..62ff652

  • superset-frontend/packages/superset-core/src/translation/index.ts
  • superset-frontend/packages/superset-core/src/translation/types/index.ts
  • superset-frontend/packages/superset-core/src/translation/types/jed.ts
  • superset-frontend/packages/superset-ui-chart-controls/src/types.ts
  • superset-frontend/packages/superset-ui-core/src/chart/index.ts
  • superset-frontend/packages/superset-ui-core/src/chart/types/Base.ts
  • superset-frontend/packages/superset-ui-core/src/chart/types/QueryResponse.ts
  • superset-frontend/packages/superset-ui-core/src/chart/types/TransformFunction.ts
  • superset-frontend/packages/superset-ui-core/src/connection/index.ts
  • superset-frontend/packages/superset-ui-core/src/connection/types.ts
  • superset-frontend/packages/superset-ui-core/src/dimension/index.ts
  • superset-frontend/packages/superset-ui-core/src/dimension/types.ts
  • superset-frontend/packages/superset-ui-core/src/query/api/legacy/index.ts
  • superset-frontend/packages/superset-ui-core/src/query/api/legacy/types.ts
  • superset-frontend/packages/superset-ui-core/src/query/types/AdvancedAnalytics.ts
  • superset-frontend/packages/superset-ui-core/src/query/types/Column.ts
  • superset-frontend/packages/superset-ui-core/src/query/types/Dashboard.ts
  • superset-frontend/packages/superset-ui-core/src/query/types/Datasource.ts
  • superset-frontend/packages/superset-ui-core/src/query/types/Metric.ts
  • superset-frontend/packages/superset-ui-core/src/query/types/Query.ts
  • superset-frontend/packages/superset-ui-core/src/query/types/QueryFormData.ts
  • superset-frontend/packages/superset-ui-core/src/query/types/QueryResponse.ts
  • superset-frontend/packages/superset-ui-core/src/query/types/Time.ts
  • superset-frontend/packages/superset-ui-core/src/query/types/index.ts
  • superset-frontend/plugins/plugin-chart-ag-grid-table/src/index.ts
  • superset-frontend/plugins/plugin-chart-ag-grid-table/src/types.ts
  • superset-frontend/plugins/plugin-chart-table/src/index.ts
  • superset-frontend/plugins/plugin-chart-table/src/types.ts
  • superset-frontend/src/explore/components/controls/ColumnConfigControl/index.tsx
  • superset-frontend/src/explore/components/controls/ColumnConfigControl/types.ts
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.08%. Comparing base (4535499) to head (62ff652).
⚠️ Report is 28 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #42190   +/-   ##
=======================================
  Coverage   65.08%   65.08%           
=======================================
  Files        2758     2758           
  Lines      155229   155229           
  Branches    35572    35572           
=======================================
  Hits       101026   101026           
  Misses      52288    52288           
  Partials     1915     1915           

Flag	Coverage Δ
javascript	70.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.